Skip to content

feat(serve): skip transcode completion if encore job has no audio output#86

Merged
Lunkers merged 3 commits into
mainfrom
fix/verify-audio
Apr 10, 2026
Merged

feat(serve): skip transcode completion if encore job has no audio output#86
Lunkers merged 3 commits into
mainfrom
fix/verify-audio

Conversation

@Lunkers

@Lunkers Lunkers commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Added a guard in handleTranscodeCompleted that checks for at least one audio stream using HasAudioOutput() before creating a TranscodeInfo
  • If no audio output is present, the job is removed from the store and processing is skipped
  • Updated EncoreHandlerStub in tests to include an audio output stream

🤖 Generated with Claude Code

Lunkers and others added 3 commits April 10, 2026 10:58
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Lunkers Lunkers requested a review from Nfrederiksen April 10, 2026 11:40

@Nfrederiksen Nfrederiksen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lgtm

@Lunkers Lunkers merged commit d09e64d into main Apr 10, 2026
4 checks passed
@Lunkers Lunkers deleted the fix/verify-audio branch April 10, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants