Skip to content

Fix Lab rig bench snapshot resolution#3937

Merged
chubes4 merged 2 commits into
mainfrom
fix/issue-3933-lab-snapshot-component
Jun 10, 2026
Merged

Fix Lab rig bench snapshot resolution#3937
chubes4 merged 2 commits into
mainfrom
fix/issue-3933-lab-snapshot-component

Conversation

@chubes4

@chubes4 chubes4 commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Prefer the offloaded primary source snapshot when a Lab-offloaded rig exists in the current source tree, avoiding stale runner-side rig source metadata.
  • Inject the primary snapshot as --path for Lab-offloaded bench --rig runs without an explicit path so default component resolution cannot fall back to a stale runner component checkout.
  • Add Lab plan/metadata diagnostics for the source snapshot remote path and selected rig install sources.

Fixes #3933.

Tests

  • cargo fmt --check
  • cargo test core::runner::rig_materialization
  • cargo test core::runner::lab::preparation_tests
  • cargo test core::extension::bench::run::tests::attach_memory_timeline_adds_metrics_and_artifacts
  • cargo test (one unrelated/flaky failure: core::extension::bench::run::tests::attach_memory_timeline_adds_metrics_and_artifacts; reran that single test and it passed)

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Investigating the Lab offload rig resolution path, implementing the fix, and drafting regression tests. Chris remains responsible for review and validation.

@homeboy-ci

homeboy-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — homeboy

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint homeboy --baseline
Deep dive: homeboy lint homeboy --changed-since 8f68bc8

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-lint-quality-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-lint-quality-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/27285510963

Test

test — failed

  • 1 failed out of 4191 total
  • 18 skipped

ℹ️ To run specific tests: homeboy test homeboy -- --filter=TestName
ℹ️ Set --setting require_phpunit_tests=true when this component is expected to contain PHPUnit tests.
ℹ️ Auto-fix lint issues: homeboy refactor homeboy --from lint --write
ℹ️ Collect coverage: homeboy test homeboy --coverage
ℹ️ Analyze failures: homeboy test homeboy --analyze
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test homeboy --changed-since 8f68bc8

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-test-quality-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-test-quality-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/27277857864

Audit

audit — passed

  • core_boundary_leak:core-agnostic-source — 2 finding(s)
  • field_patterns — 2 finding(s)
  • structural — 2 finding(s)
  • Runs (Tests) — 1 finding(s)
  • intra-method-duplication — 1 finding(s)
  • Total: 8 finding(s)

Deep dive: homeboy audit homeboy --changed-since 8f68bc8

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-audit-quality-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-audit-quality-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/27285510963
Tooling versions
  • Homeboy CLI: homeboy 0.227.9+ffc0ea20
  • Extension: rust from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 8758c05d
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 757f575 into main Jun 10, 2026
9 of 10 checks passed
@chubes4 chubes4 deleted the fix/issue-3933-lab-snapshot-component branch June 10, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lab offload should prevent stale rig component resolution

1 participant