Fix completion assertions for runtime tool aliases#2605
Merged
Conversation
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name, and provider/runtime-saferuntime_tool_idas valid completion assertion names.filesystem_writerequirement with logicalclient/filesystem-writeexecution in the request-builder smoke test.Why
Latest WP Codebox exposed Studio Web browser generation failing before tool execution with:
Completion assertions require unavailable tool(s): filesystem_write.The model sees the provider-safe alias, while Data Machine executes the logical Agents API tool name. Completion assertions need to understand both names instead of rejecting the request before generation.
Testing
php tests/request-builder-tool-transcript-smoke.phpphp -l inc/Engine/AI/DataMachineCompletionAssertions.phpphp -l tests/request-builder-tool-transcript-smoke.phpAI assistance