Skip to content

Refactor workspace core utilities into trait#600

Merged
chubes4 merged 2 commits into
mainfrom
refactor/extract-workspace-core-utilities
Jun 7, 2026
Merged

Refactor workspace core utilities into trait#600
chubes4 merged 2 commits into
mainfrom
refactor/extract-workspace-core-utilities

Conversation

@chubes4

@chubes4 chubes4 commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Extract generic workspace path/security/git utility helpers into WorkspaceCoreUtilities.
  • Keep Workspace focused on trait composition, constants, constructor state, and the concrete timeout-aware default-ref resolver needed to avoid the lifecycle trait collision.
  • Reduce Workspace.php from hundreds of mixed utility lines to the small composition shell.

Verification

  • git diff --check
  • php -l inc/Workspace/Workspace.php
  • php -l inc/Workspace/WorkspaceCoreUtilities.php
  • php tests/smoke-worktree-metadata-reconcile.php
  • php tests/smoke-worktree-cleanup-cli.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Drafted the mechanical trait extraction and ran local verification; Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since d96db25

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27100302531

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since d96db25

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27100302531

Audit

audit — passed

  • audit — 57 finding(s)
  • Total: 57 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since d96db25

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27100302531
Tooling versions
  • Homeboy CLI: homeboy 0.222.8+982a508
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 76c2439e
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 4bc9a43 into main Jun 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant