Skip to content

Refactor worktree cleanup engine into trait#598

Merged
chubes4 merged 1 commit into
mainfrom
refactor/extract-worktree-cleanup-engine
Jun 7, 2026
Merged

Refactor worktree cleanup engine into trait#598
chubes4 merged 1 commit into
mainfrom
refactor/extract-worktree-cleanup-engine

Conversation

@chubes4

@chubes4 chubes4 commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Extract the general worktree cleanup engine from Workspace into WorkspaceWorktreeCleanupEngine.
  • Keep cleanup behavior wired through a trait while reducing the monolithic Workspace.php class by roughly 2,200 lines.
  • Move cleanup planning, bounded cleanup-eligible apply, summaries, stale/disk/age helpers, merge-signal checks, and scoped plan application together as one coherent cleanup slice.

Verification

  • git diff --check
  • php -l inc/Workspace/Workspace.php
  • php -l inc/Workspace/WorkspaceWorktreeCleanupEngine.php
  • php tests/smoke-worktree-metadata-reconcile.php
  • php tests/smoke-worktree-cleanup-cli.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Drafted the mechanical trait extraction and ran local verification; Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 2e9c62c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27099661539

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 2e9c62c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27099661539

Audit

audit — passed

  • audit — 80 finding(s)
  • Total: 80 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 2e9c62c

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27099661539
Tooling versions
  • Homeboy CLI: homeboy 0.222.8+1904dd7
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 76c2439e
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 044e691 into main Jun 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant