Skip to content

Refactor active cleanup into workspace trait#597

Merged
chubes4 merged 2 commits into
mainfrom
refactor/extract-active-no-signal-cleanup
Jun 7, 2026
Merged

Refactor active cleanup into workspace trait#597
chubes4 merged 2 commits into
mainfrom
refactor/extract-active-no-signal-cleanup

Conversation

@chubes4

@chubes4 chubes4 commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Extract active/no-signal cleanup evidence and apply helpers into WorkspaceActiveNoSignalCleanup.
  • Keep Workspace wired through a trait so the behavior stays unchanged while reducing the monolithic class size.

Verification

  • git diff --check
  • php -l inc/Workspace/Workspace.php
  • php -l inc/Workspace/WorkspaceActiveNoSignalCleanup.php
  • php tests/smoke-worktree-metadata-reconcile.php
  • php tests/smoke-worktree-cleanup-cli.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Drafted the mechanical trait extraction and ran local verification; Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since efc2154

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27099031082

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since efc2154

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27099031082

Audit

audit — passed

  • audit — 8 finding(s)
  • Total: 8 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since efc2154

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27099031082
Tooling versions
  • Homeboy CLI: homeboy 0.222.7+00e5dc2
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 76c2439e
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 887e7dc into main Jun 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant