Skip to content

Fix Workspace PHPStan baseline#589

Merged
chubes4 merged 3 commits into
mainfrom
fix/workspace-phpstan-baseline
Jun 7, 2026
Merged

Fix Workspace PHPStan baseline#589
chubes4 merged 3 commits into
mainfrom
fix/workspace-phpstan-baseline

Conversation

@chubes4

@chubes4 chubes4 commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Tighten Workspace helper types and PHPDoc so PHPStan can prove cleanup paths without changing cleanup behavior.
  • Remove unused constants and redundant guards flagged by the existing Workspace.php baseline.
  • Make trait-facing helpers protected so static analysis recognizes their cross-file usage.

Testing

  • php -l inc/Workspace/Workspace.php
  • git diff --check
  • php tests/smoke-worktree-metadata-reconcile.php
  • php tests/smoke-worktree-cleanup-cli.php
  • homeboy lint data-machine-code --path /Users/chubes/Developer/data-machine-code@fix-workspace-phpstan-baseline --changed-since origin/main (blocked locally: missing PHPCS binary at /Users/chubes/.config/homeboy/extensions/wordpress/vendor/bin/phpcs; emitted zero findings)

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Drafted the PHPStan/type cleanup and ran local verification; Chris remains responsible for review and submission.

@homeboy-ci

homeboy-ci Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 502add7

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27094968763

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 502add7

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27094968763

Audit

audit — passed

  • audit — 9 finding(s)
  • Total: 9 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 502add7

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27094968763
Tooling versions
  • Homeboy CLI: homeboy 0.222.4+79438b8
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: ab112fd6
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 94b7b66 into main Jun 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant