Phase 0: Auth-path regression net (characterization + factory tests) - #19
Closed
diegohb wants to merge 4 commits into
Closed
Phase 0: Auth-path regression net (characterization + factory tests)#19diegohb wants to merge 4 commits into
diegohb wants to merge 4 commits into
Conversation
added 4 commits
August 7, 2026 23:54
Phase 0 framework (per architecture review + grilling 2026-08-07): - CONTEXT.md (new): domain glossary for auth + chat modules - docs/phase-0/plan.md (new): executable Phase 0 plan (3 OpenSpec changes) - docs/phantom-bug-synthesis.md (renamed from docs/phantom-auth-synthesis-2026-08-06.md via git mv): now a write-once ledger of bug history; sessions 1-3 content preserved; empty Appendix ready for post-fix-failure entries; §Phase 0 framing stripped (was planning, not bug history) Agent skills config (per setup-matt-pocock-skills): - docs/agents/issue-tracker.md: GitHub Issues via gh CLI + tskNN- ticket-id prefix convention - docs/agents/domain.md: single-context layout + write-once ledger convention for the bug ledger - docs/agents/triage-labels.md: five-role vocabulary (needs-triage, needs-info, ready-for-agent, ready-for-human, wontfix) - AGENTS.md: ## Agent skills block appended Refs: - architecture-review-auth-2026-08-07.html (temp) — visual review - handoff-phase0-2026-08-07.md (temp) — for the next session Next: branch phase0/regression-net off main@v2.6.1.
Member
Author
|
Closing in favor of the Phase 0 v2 design. The Phase 0 v1 design (cookie-aware fake via full-stack-fixture) had a structural flaw: the fixture is 'constant-ok' and cannot catch the 4-cookie bug as the test-list claimed. All 19 tests are GREEN on every branch (dev, prod, fix). The replacement is Phase 0 v2 — a 10-test suite across 6 files, with the cookie-monitor.test.ts backport from this branch as the 0a foundation. See docs/phase-0/investigation-report.md, docs/phase-0/phase-0-v2-design.md, and the §Phase 0 v2 addendum in the architecture review HTML for full details. The fix branch (fix/v2.6.1-bugs) already has the correct fix (6bc51f6); Phase 0 v2 provides the regression net at the right seam (CookieMonitor, not the mediator). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 — Regression Net for Auth + Chat Modules
This PR lands the Phase 0 regression net on main as a characterization test suite. The tests document the expected round-trip behavior at the ProfileAuthManager + IGeminiClientService integration seam.
What's included
3 OpenSpec change dirs:
No production code changes. Phase 0 is test-only.
Test results
Next steps