Skip to content

Phase 0: Auth-path regression net (characterization + factory tests) - #19

Closed
diegohb wants to merge 4 commits into
mainfrom
phase0/regression-net
Closed

Phase 0: Auth-path regression net (characterization + factory tests)#19
diegohb wants to merge 4 commits into
mainfrom
phase0/regression-net

Conversation

@diegohb

@diegohb diegohb commented Aug 8, 2026

Copy link
Copy Markdown
Member

Phase 0 — Regression Net for Auth + Chat Modules

This PR lands the Phase 0 regression net on main as a characterization test suite. The tests document the expected round-trip behavior at the ProfileAuthManager + IGeminiClientService integration seam.

What's included

3 OpenSpec change dirs:

  • sk03-phase0-synthesis-journal — formalizes the write-once ledger convention for docs/phantom-bug-synthesis.md
  • sk01-phase0-regression-net-char — new ests/helpers/full-stack-fixture.ts + ests/services/regression-net.test.ts (10 tests)
  • sk02-phase0-factory-coverage — new ests/cli/get-gemini-client.test.ts (9 tests)

No production code changes. Phase 0 is test-only.

Test results

  • �un run typecheck — clean
  • �un test — 928 pass / 0 fail / 2 skip (19 new tests added to v2.6.1 baseline of 909)

Next steps

  1. ix/v2.6.1-bugs merges main (Phase 0 in)
  2. ix/v2.6.1-bugs adds an integration test exercising the full stack
  3. Tests turn GREEN when fixes (6bc51f6, a780788, 4dfe13c, 9762845, 809240a, 0f9154f) are verified
  4. Merge to main, tag v2.6.2

diegohb added 4 commits August 7, 2026 23:54
Phase 0 framework (per architecture review + grilling 2026-08-07):
- CONTEXT.md (new): domain glossary for auth + chat modules
- docs/phase-0/plan.md (new): executable Phase 0 plan (3 OpenSpec changes)
- docs/phantom-bug-synthesis.md (renamed from docs/phantom-auth-synthesis-2026-08-06.md via git mv): now a write-once ledger of bug history; sessions 1-3 content preserved; empty Appendix ready for post-fix-failure entries; §Phase 0 framing stripped (was planning, not bug history)

Agent skills config (per setup-matt-pocock-skills):
- docs/agents/issue-tracker.md: GitHub Issues via gh CLI + tskNN- ticket-id prefix convention
- docs/agents/domain.md: single-context layout + write-once ledger convention for the bug ledger
- docs/agents/triage-labels.md: five-role vocabulary (needs-triage, needs-info, ready-for-agent, ready-for-human, wontfix)
- AGENTS.md: ## Agent skills block appended

Refs:
- architecture-review-auth-2026-08-07.html (temp) — visual review
- handoff-phase0-2026-08-07.md (temp) — for the next session

Next: branch phase0/regression-net off main@v2.6.1.
@diegohb

diegohb commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

Closing in favor of the Phase 0 v2 design. The Phase 0 v1 design (cookie-aware fake via full-stack-fixture) had a structural flaw: the fixture is 'constant-ok' and cannot catch the 4-cookie bug as the test-list claimed. All 19 tests are GREEN on every branch (dev, prod, fix). The replacement is Phase 0 v2 — a 10-test suite across 6 files, with the cookie-monitor.test.ts backport from this branch as the 0a foundation. See docs/phase-0/investigation-report.md, docs/phase-0/phase-0-v2-design.md, and the §Phase 0 v2 addendum in the architecture review HTML for full details. The fix branch (fix/v2.6.1-bugs) already has the correct fix (6bc51f6); Phase 0 v2 provides the regression net at the right seam (CookieMonitor, not the mediator).

@diegohb diegohb closed this Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant