Skip to content

Revert "Composer: add clear command that bypasses the event count"#46626

Merged
roryabraham merged 1 commit into
mainfrom
revert-46091-fix/37896-composer-not-cleared
Aug 1, 2024
Merged

Revert "Composer: add clear command that bypasses the event count"#46626
roryabraham merged 1 commit into
mainfrom
revert-46091-fix/37896-composer-not-cleared

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Reverts #46091

@github-actions

github-actions Bot commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

@roryabraham roryabraham marked this pull request as ready for review August 1, 2024 18:03
@roryabraham roryabraham requested a review from a team as a code owner August 1, 2024 18:03
@roryabraham roryabraham self-assigned this Aug 1, 2024
@melvin-bot melvin-bot Bot removed the request for review from a team August 1, 2024 18:04
@melvin-bot

melvin-bot Bot commented Aug 1, 2024

Copy link
Copy Markdown

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested a review from blimpich August 1, 2024 18:04
@roryabraham

roryabraham commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author

merging straight revert without checklists, tested AdHoc w/ applause: https://expensify.slack.com/archives/C9YU7BX5M/p1722531831074969

@roryabraham roryabraham merged commit 7ef4912 into main Aug 1, 2024
@roryabraham roryabraham deleted the revert-46091-fix/37896-composer-not-cleared branch August 1, 2024 18:06
@melvin-bot melvin-bot Bot added the Emergency label Aug 1, 2024
@melvin-bot

melvin-bot Bot commented Aug 1, 2024

Copy link
Copy Markdown

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

OSBotify commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 1, 2024
…ser-not-cleared

Revert "Composer: add clear command that bypasses the event count"

(cherry picked from commit 7ef4912)
@OSBotify

OSBotify commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.15-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

OSBotify commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@hannojg

hannojg commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Opened a new PR with a proper fix here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants