fix(security): don't flag ../../ inside Markdown link targets as directory traversal - #19
Open
vladimirrterekhin-hit wants to merge 1 commit into
Conversation
…ctory traversal ../../ inside a Markdown link target (](../../x.md)) is a documentation reference, not a filesystem operation, but D3 flagged it as medium "Directory traversal pattern detected", pushing clean skills from PASS to CAUTION. Adds a narrow guard (isInsideMarkdownLink) that skips only the medium traversal finding inside an unclosed link; real shell/code traversal is untouched. Adds runMarkdownLinkTraversalChecks to verify-local.js. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
../../inside a Markdown link target (](../../x.md)) is a documentationreference, not a filesystem operation, but D3 flagged it as medium
"Directory traversal pattern detected", pushing otherwise-clean skills from
PASS to CAUTION.
Change
lib/security-validator.js: narrow guard in theprivilegePatternsloop +isInsideMarkdownLink()helper. Skips only the medium traversal finding whenthe match is inside an unclosed
](...link. No other pattern/severityaffected.
scripts/tests/verify-local.js:runMarkdownLinkTraversalChecks()—asserts doc links produce 0 traversal findings and that a real
cat ../../../etc/passwdstill flags. Uses the inlinefs.mkdtempSyncfixture convention (no committed fixture).
Verification:
npm run verify:localgreen (afternpm run build:oc).+82 / −1 across 2 files.
🤖 Generated with Claude Code