Replace monotonic-align from source by our published ilt-monotonic-align#812
Merged
Conversation
Changed Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 45 45
Lines 4033 4033
Branches 605 605
=======================================
Hits 3531 3531
Misses 365 365
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
098d763 to
3475ac6
Compare
3475ac6 to
7f0d5d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Get ilt-monotonic-align from PyPI instaed of github, so we can publish the next EveryVoice version.
This is a draft to review the publication process of ilt-monotonic-align, which is currently only published on test.pypi.org.
Please test with this PR and if we're happy with it, then I'll actually publish to regular PyPI.
Source code for our ilt-monotonic-align fork: https://github.com/EveryVoiceTTS/monotonic_align
Fixes?
Fixes EveryVoiceTTS/StyleTTS2#8
Feedback sought?
Please test and make sure it works for you.
Also please review
EveryVoiceTTS/monotonic_align@c6e5e6c...783173d
which is the diff between the repo we forked and what I have done, specifically for how I declare Copyright and maintainer, and general sanity checking. The intent at this point was to do the minimal changes required to be able to publish, so ignore "would-be-nice" elements, just review for actual problems.
Priority?
before we publish 0.5.0
Tests added?
yes
How to test?
By default, pip or uv won't fetch packages from testpypi, you need to add
--index-strategy unsafe-best-match --extra-index-url https://test.pypi.org/simpleto make that happen.The lock file
uv.lockfile is already updated to point to testpypi for this one package, so justwill work.
(Once we publish ilt-monotonic-align to PyPI, I'll update the lock file again accordingly.)
Otherwise, you can do
Then, launch training of a styletts2 model and make sure it gets past the point where it need monotonic-align. @roedoejet when is that anyway?
Confidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/StyleTTS2#10