[StyleTTS2] load pretrained checkpoint from HuggingFace#807
Conversation
Changed Files
|
83961c7 to
e02782e
Compare
|
the new-project wizard still expected the pre-trained files to exist |
|
The concept is good here. For the local override, we could put a warning in the field's documentation that it gets saved in the models. Also, we could support |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev.ap/styletts2-improvements #807 +/- ##
==============================================================
Coverage 84.98% 84.99%
==============================================================
Files 46 46
Lines 4217 4219 +2
Branches 632 632
==============================================================
+ Hits 3584 3586 +2
Misses 494 494
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0610813 to
8a744b3
Compare
good idea. I've added this. |
a5b2a20 to
e8c84a4
Compare
0aa45f4 to
d9de20b
Compare
1ac2571 to
cca19c5
Compare
use default hf models instead re-generate schema and change test config as well
8b813f5 to
149600f
Compare
PR Goal?
Loading pretrained models from within the codebase is messy since we need to handle the paths, and the model checkpoints bloat the package/our git history.
Fixes?
An element of #686
Feedback sought?
Does this look reasonable? I think the "local override" option is still not going to be handled well since it will put a potentially absolute path in the config.
Priority?
high
Tests added?
None
How to test?
if you train a model with this branch, you should see the HF models downloading automatically
Confidence?
medium
Version change?
n/a
Related PRs?
EveryVoiceTTS/StyleTTS2#6
Once accepted, we'll need to clean the git history of any *.t7 or *.pth files