Skip to content

chore: whole new penal code for a whole new MDT#19

Open
somefriggnidiot wants to merge 71 commits into
Everfall-Development:masterfrom
somefriggnidiot:mergeme
Open

chore: whole new penal code for a whole new MDT#19
somefriggnidiot wants to merge 71 commits into
Everfall-Development:masterfrom
somefriggnidiot:mergeme

Conversation

@somefriggnidiot

@somefriggnidiot somefriggnidiot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This time in the proper repo.

Summary by CodeRabbit

  • Chores
    • Updated project configuration files.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 416f1367-021d-47cd-b7df-455478d1cf19

📥 Commits

Reviewing files that changed from the base of the PR and between af1491c and 9d33a64.

📒 Files selected for processing (2)
  • .gitignore
  • ef-mdt-penal-code.json

📝 Walkthrough

Walkthrough

A single line is added to .gitignore to exclude the util/ directory from Git tracking.

Changes

Gitignore Update

Layer / File(s) Summary
Add util/ ignore rule
.gitignore
Adds util/ to .gitignore so all files under that directory are ignored by Git.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minutes

Suggested reviewers

  • jellyton255

Poem

🐇 Hippity hoppity, what do we see?
A util/ folder, now wild and free!
Git shall not track it, not even a byte,
One line in .gitignore sets it all right.
The bunny hops onward, tidy and bright! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes a penal code system overhaul, but the only file changed in this PR is .gitignore with a utility directory ignore rule added. Update the title to reflect the actual changes, such as 'chore: add util directory to .gitignore' or investigate if this PR contains the incorrect changeset.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jellyton255

Copy link
Copy Markdown
Member

No json + want proper types.

@somefriggnidiot

Copy link
Copy Markdown
Contributor Author

No json + want proper types.

This is already in live. Please open an issue against the current state for preferential refactor requests.

@jellyton255

Copy link
Copy Markdown
Member

Well, fix, and it'll be reimplemented with the PROPER implementation.

@jellyton255

Copy link
Copy Markdown
Member

This is a BLOCKER for main site implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants