Skip to content

Stop emitting tokens with default decimals=18 when metadata is missing #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benwoody wants to merge 1 commit into
base: feature-token_extensions
Choose a base branch
from
Open

Stop emitting tokens with default decimals=18 when metadata is missing #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 4 additions & 30 deletions core/data/src/main/java/com/core/data/repository/AlchemyTokenBalanceRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ class AlchemyTokenBalanceRepository @Inject constructor(

override fun getCombinedTokens(): Flow<List<TokenAsset>> =
tokenBalanceDao.getCompositeTokens().map { allCompositeTokens ->
// Group tokens: those with metadata by symbol, those without separately
// Skip tokens without metadata; defaulting decimals to 18 would
// misreport balances for non-18-decimal tokens (USDC, USDT, etc.).
val tokensWithMetadata = allCompositeTokens.filter { it.tokenMetadataEntity != null }
val tokensWithoutMetadata = allCompositeTokens.filter { it.tokenMetadataEntity == null && it.tokenBalanceEntity != null }

// Process tokens with metadata (group by symbol)
val groupedBySymbol = tokensWithMetadata.groupBy { it.tokenMetadataEntity!!.symbol }
Expand Down Expand Up @@ -87,34 +87,8 @@ class AlchemyTokenBalanceRepository @Inject constructor(
)
}
}

// Process tokens without metadata (use contract address as identifier)
val assetsWithoutMetadata = tokensWithoutMetadata.map { compositeToken ->
val balanceEntity = compositeToken.tokenBalanceEntity!!
// Use default decimals of 18 for tokens without metadata
val decimals = 18
val balance = balanceEntity.tokenBalance
.movePointLeft(decimals)
.stripTrailingZeros()
.toDouble()

// Use shortened address as symbol/name for now
val shortAddress = "${balanceEntity.contractAddress.take(6)}...${balanceEntity.contractAddress.takeLast(4)}"

TokenAsset(
address = balanceEntity.contractAddress,
chainId = balanceEntity.chainId,
symbol = shortAddress,
name = "Unknown Token",
balance = balance,
decimals = decimals,
logoUrl = null,
swappable = false
)
}

// Combine both lists
assetsWithMetadata + assetsWithoutMetadata

assetsWithMetadata
}

override fun getTokensBalances(): Flow<List<TokenBalance>> =
Expand Down