feat(browser): find in page (Ctrl+F) - #12
Merged
Merged
Conversation
Floating find bar in the chrome, triggered by Ctrl+F, over webContents before-input-event. Drives webContents.findInPage on the active page: - incremental highlight while typing - Enter / Shift+Enter jump to next / previous match - match-case toggle (Aa) - live match counter (active/total) from the found-in-page event - Esc or × closes and clears the selection (stopFindInPage) New IPC: findShow (main→chrome), findQuery/findStop (chrome→main), findResult (main→chrome). Reuses chromeExpand so the bar floats over the page without being clipped by the chrome view bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Barra de búsqueda flotante en la página (Ctrl+F), sobre
webContents.findInPage.found-in-page).stopFindInPage).Nuevos IPC:
findShow(main→chrome),findQuery/findStop(chrome→main),findResult(main→chrome). ReusachromeExpandpara que la barra flote sobre la página sin recortarse.Verificación
npm run typecheck✅npm run build✅