Skip to content

Holochain 0.6.1 upgrade — sweettest tests, UI dep modernization #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThetaSinner wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Holochain 0.6.1 upgrade — sweettest tests, UI dep modernization #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ecbbf0e
feat: Update to Holochain 0.6.1-rc.8
ThetaSinner Apr 22, 2026
b23eafa
ci: Bump action versions and align Nix install URL
ThetaSinner Apr 23, 2026
6df1ab3
fixup! feat: Update to Holochain 0.6.1-rc.8
ThetaSinner Apr 23, 2026
02501a3
build(flake): Migrate from crane.lib to crane.mkLib
ThetaSinner Apr 23, 2026
237cdf3
build(flake): Update flake.lock
ThetaSinner Apr 23, 2026
bfb7c3b
chore(cargo): Bump non-Holochain dependencies
ThetaSinner Apr 24, 2026
1d248b6
fix(cli): Resolve upstream dep conflicts and update test API for HC 0…
ThetaSinner Apr 24, 2026
08d811f
test: Migrate tryorama integration tests to sweettest
ThetaSinner Apr 25, 2026
ccbbbf1
chore(types): Bump types crates to edition 2024
ThetaSinner Apr 25, 2026
1535700
chore(ui): Modernize dependency stack and adopt Tailwind v4
ThetaSinner Apr 25, 2026
b475004
ci: Refresh test workflow for sweettest and dedup CLI matrix
ThetaSinner Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/flake_update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@ jobs:
flake_update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Install nix
uses: cachix/install-nix-action@v31
with:
install_url: https://releases.nixos.org/nix/nix-2.25.4/install
install_url: https://releases.nixos.org/nix/nix-2.34.6/install

- name: Flake update
run: |
nix flake update

- name: Create Pull Request
uses: peter-evans/create-pull-request@v7
uses: peter-evans/create-pull-request@v8
with:
commit-message: "chore: Update flake.lock"
title: "Update flake.lock"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Install nix
uses: cachix/install-nix-action@v31
with:
install_url: https://releases.nixos.org/nix/nix-2.25.4/install
install_url: https://releases.nixos.org/nix/nix-2.34.6/install

- uses: cachix/cachix-action@v16
- uses: cachix/cachix-action@v17
with:
name: esl-checked
extraPullNames: holochain-ci
Comment on lines +26 to 29
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Missing authToken for cachix/cachix-action@v17 — release builds will not push to the binary cache.

Compared to .github/workflows/test.yaml (lines 26-29 in the relevant snippet) which passes authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}, this release job omits it. Without an auth token, cachix is read-only: derivations built during release won't be pushed to esl-checked, so subsequent CI/dev environments lose the caching benefit of the release build. If this is intentional (e.g., release should not write to cache), a brief comment would help; otherwise add the token.

🔧 Proposed fix 
       - uses: cachix/cachix-action@v17
         with:
           name: esl-checked
           extraPullNames: holochain-ci
+          authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: cachix/cachix-action@v17
with:
name: esl-checked
extraPullNames: holochain-ci
- uses: cachix/cachix-action@v17
with:
name: esl-checked
extraPullNames: holochain-ci
authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yaml around lines 26 - 29, The cachix step using
cachix/cachix-action@v17 in the release workflow is missing the authToken so it
cannot push artifacts to the esl-checked cache; update the step for the release
job (the cachix action block) to include authToken: ${{
secrets.CACHIX_AUTH_TOKEN }} so release builds can push, or if intentional, add
a brief comment above the cachix step explaining why writes are disabled for
releases; target the cachix action block (uses: cachix/cachix-action@v17 / with:
name: esl-checked) when making this change.

Expand Down Expand Up @@ -61,9 +61,9 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- uses: actions/setup-go@v5
- uses: actions/setup-go@v6
with:
go-version: '^1.23.5'

Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- uses: Swatinem/rust-cache@v2

- name: Install nix
uses: cachix/install-nix-action@v31
with:
install_url: https://releases.nixos.org/nix/nix-2.28.3/install
install_url: https://releases.nixos.org/nix/nix-2.34.6/install

- uses: cachix/cachix-action@v16
- uses: cachix/cachix-action@v17
with:
name: esl-checked
extraPullNames: holochain-ci
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
run: |
nix develop --command npm --workspace ui run build

- name: Run Tryorama tests
- name: Run integration tests
run: |
nix develop --command npm run test:integration

Expand All @@ -63,21 +63,21 @@ jobs:
cli-test:
strategy:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
# ubuntu-latest is already covered by the nix-based `test` job above,
# which runs `npm run test:cli` against the same CLI suite.
os: [ macos-latest, windows-latest ]
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4

- uses: Swatinem/rust-cache@v2
- uses: actions/checkout@v6

- uses: Swatinem/rust-cache@v2

- name: Run CLI tests
run: |
cargo install holochain_cli@0.5.2 --locked
cargo install holochain_cli@0.6.1-rc.8 --locked

cargo build --release --target wasm32-unknown-unknown
RUSTFLAGS='--cfg getrandom_backend="custom"' cargo build --release --target wasm32-unknown-unknown
hc app pack workdir --recursive

# Tests are independent but sweettest is so resource hungry that they run slower in parallel.
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@

/node_modules/
/tests/node_modules/
/dist/
/target/
/.cargo/
Expand All @@ -16,3 +15,4 @@
*.pub
*.minisig
checked_cli/target
tests/target
Loading
Loading