fix(review): recalibrate interactive findings - #463
Merged
Conversation
Deploying allagents with
|
| Latest commit: |
ae94667
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd9ab3f3.allagents.pages.dev |
| Branch Preview URL: | https://fix-pr-interactive-review-fe.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Interactive PR review comments could disprove a finding while the original card, severity, scenario, counts, and verdict remained stale. Scenario sidecars could assert an active failure without separate reachability and outcome provenance.
Behavior
review.jsonworkspaces from v1 to v2 deterministically;comments.jsonremains v1.active,question, andwithdrawnfinding states, immutable original claims, and append-only comment-linked revisions throughPOST /api/findings/%23<id>/revisions.Security
The new route reuses JSON content-type validation, same-origin write enforcement, request size limits, bounded atomic persistence, per-review locking, comment-to-finding linkage, loopback-by-default hosting, and no GitHub posting. The non-loopback warning now explicitly includes lifecycle revisions.
Verification
bun test tests/unit/plugins/pr-interactive-review.test.ts— 13 passing tests.bun run typecheck— passed.bun run lint— passed (92 source files).bun run build— passed.No active findings,Withdrawn findings (1), preserved comment/reply and lifecycle history; narrow viewport had no document horizontal overflow (scrollWidth 375atinnerWidth 390).