Skip to content

fix(eval): reject authored execution concurrency - #1634

Merged
christso merged 1 commit into
mainfrom
promptfoo-concurrency-align
Jul 4, 2026
Merged

fix(eval): reject authored execution concurrency#1634
christso merged 1 commit into
mainfrom
promptfoo-concurrency-align

Conversation

@christso

@christso christso commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Authored eval YAML now rejects execution.max_concurrency and directs authors to evaluate_options.max_concurrency, matching the Promptfoo evaluateOptions.maxConcurrency convention while preserving .agentv/config.yaml execution.max_concurrency as operator run policy.

This also updates validator/parser tests, regenerated eval schema data, public v4.42.4 eval docs, and migration guidance so removed workers paths no longer send users back to the removed authored execution.max_concurrency surface.

Validation

  • bun test packages/core/test/evaluation/loaders/config-loader.test.ts packages/core/test/evaluation/validation/eval-file-schema.test.ts packages/core/test/evaluation/validation/eval-validator.test.ts packages/core/test/evaluation/validation/eval-schema-sync.test.ts
  • bun test packages/core/test/evaluation/eval-inline-experiment.test.ts packages/core/test/evaluation/config.test.ts
  • bun run validate:examples
  • bun run build
  • bun run lint
  • Manual red/green CLI validation:
    • execution.max_concurrency eval fails with guidance to evaluate_options.max_concurrency
    • evaluate_options.max_concurrency eval validates successfully

Live provider/grader dogfood was not run because this changes eval authoring validation/schema/docs only; it does not change provider execution, grader behavior, run artifacts, or result provenance.

Review Notes

  • Promptfoo source evidence checked against local clone /home/entity/projects/promptfoo/promptfoo at 6bfc5a0c7f16f9c4717ac731d276b578e63d0769.
  • Dedicated subagent review was skipped because the available Codex subagent tool requires explicit user authorization for delegation; inline simplify/review pass found no behavior-preserving follow-up changes.

Post-Deploy Monitoring & Validation

No additional production monitoring required. This is a local validation/schema/docs change with no service runtime path.

Expected healthy signals:

  • CI build, lint, schema sync, and example validation pass.
  • Users authoring evaluate_options.max_concurrency continue to validate and run.
  • Users authoring execution.max_concurrency in eval YAML receive the new actionable validation error.

Failure signals and rollback trigger:

  • CI schema sync or example validation fails.
  • Valid eval files using evaluate_options.max_concurrency are rejected.
  • .agentv/config.yaml execution.max_concurrency stops working as project/operator policy.

Validation window and owner: PR review and GitHub Actions before merge; coordinator owns Bead closure after merge.

Related

Related: av-kfik.23


Compound Engineering
GPT-5

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 453291e
Status: ✅  Deploy successful!
Preview URL: https://bbd40a63.agentv.pages.dev
Branch Preview URL: https://promptfoo-concurrency-align.agentv.pages.dev

View logs

@christso
christso marked this pull request as ready for review July 4, 2026 05:36
@christso
christso merged commit b6d5003 into main Jul 4, 2026
8 checks passed
@christso
christso deleted the promptfoo-concurrency-align branch July 4, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant