Skip to content

docs(sdk): clarify custom assertion terminology - #1633

Merged
christso merged 1 commit into
mainfrom
promptfoo-custom-terms
Jul 4, 2026
Merged

docs(sdk): clarify custom assertion terminology#1633
christso merged 1 commit into
mainfrom
promptfoo-custom-terms

Conversation

@christso

@christso christso commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Clarifies that defineAssertion() and .agentv/assertions/ define reusable custom assertion types, not custom graders.
  • Reserves custom/script grader terminology for command-backed or LLM-backed scoring components, especially defineScriptGrader() with type: script.
  • Adds Promptfoo parity/divergence notes: Promptfoo custom logic normally uses fixed assertion types such as javascript, python, ruby, and webhook; AgentV extends this with arbitrary discovered assertion type names.
  • Updates public docs, SDK README/JSDoc/package metadata, examples, and skills-data references with cross-links so users can choose the right mechanism.

Promptfoo source checked locally at /home/entity/projects/promptfoo/promptfoo commit 6bfc5a0c7f16f9c4717ac731d276b578e63d0769.

Validation

  • bun install
  • bun --filter @agentv/sdk typecheck
  • bun --filter @agentv/sdk test (92 tests passed)
  • bun run build in apps/web
  • bun run check:routes in apps/web
  • bun run lint
  • git diff --check

Docs build emitted existing Pagefind/Starlight warnings about /docs/next/* pages without outer <html> elements; build completed successfully and route checks passed.

Manual Review

Dedicated ce-code-review subagent dispatch was not available as a direct command in this Codex session, so I performed a manual diff scan focused on broken docs links, stale package-facing terms, and assertion/grader terminology contradictions. No known residual findings.

Post-Deploy Monitoring & Validation

No additional operational monitoring required. This is a documentation, examples, SDK metadata, and JSDoc terminology-only change with no runtime behavior changes.

Bead

  • av-kfik.20

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 402f46f
Status: ✅  Deploy successful!
Preview URL: https://158028cd.agentv.pages.dev
Branch Preview URL: https://promptfoo-custom-terms.agentv.pages.dev

View logs

@christso
christso marked this pull request as ready for review July 4, 2026 05:31
@christso
christso merged commit 445f6e7 into main Jul 4, 2026
8 checks passed
@christso
christso deleted the promptfoo-custom-terms branch July 4, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant