fix(eval): accept target id in targets files - #1631
Merged
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
a59fa76
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7d909e2.agentv.pages.dev |
| Branch Preview URL: | https://fix-targets-id-validation.agentv.pages.dev |
christso
force-pushed
the
fix/targets-id-validation
branch
from
July 4, 2026 04:06
cfa9236 to
dbb30c2
Compare
Entire-Checkpoint: ef8f54a28ee7
christso
force-pushed
the
fix/targets-id-validation
branch
from
July 4, 2026 04:31
dbb30c2 to
a59fa76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live quickstart evals can now execute against checked-in
targets.yamlfiles that use the currentidtarget identity. Before this, the merged README/example contract validated butagentv eval runstill rejectedtargets.yamlat runtime withMissing or invalid 'label' field.This keeps
nameas the internal resolver key, rejects authoredlabel/nameat validation boundaries, and migrates the tracked target templates/examples toidso new projects and examples use the supported schema directly.Related: av-kyv3
Validation
bun test packages/core/test/evaluation/providers/targets-file.test.ts packages/core/test/evaluation/providers/targets.test.ts packages/core/test/evaluation/validation/targets-validator.test.ts packages/core/test/evaluation/loaders/config-loader.test.tsbun --filter @agentv/core buildbun run validate:examples(107 valid, 0 invalid)bun run lintbun run typecheckgit diff --checkLOCAL_OPENAI_PROXY_BASE_URL=http://127.0.0.1:10531/v1 LOCAL_OPENAI_PROXY_API_KEY=local-dummy-key LOCAL_OPENAI_PROXY_MODEL=gpt-5.3-codex-spark bun apps/cli/src/cli.ts eval run examples/features/readme-quickstart/evals/my-eval.eval.yaml --workers 2 --threshold 0.8 --verbose.agentv/results/2026-07-04T03-57-29-236Z; result was PASS, 1/1 tests, mean score 100%,grading.jsonscore 1 verdict pass with 5/5 assertion_results passing.