fix(artifacts): keep eval runs at timestamp root - #1580
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
24b9912
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://24327a53.agentv.pages.dev |
| Branch Preview URL: | https://target-layout-implementation.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalize the v1 run artifact layout so a timestamped run bundle owns one root
index.jsonlmanifest and one rootsummary.json. New eval runs no longer fan out into target or variant directories; target/model/variant remain metadata, and per-result artifacts stay discoverable through explicit manifest fields likeresult_dir,summary_path,grading_path,metrics_path, andtranscript_path.What Changed
agentv eval.internal/v2 option.Code Review
origin/mainwith correctness, testing, maintainability, project-standards, agent-native, and learnings lenses.Validation
bun test apps/cli/test/commands/eval/result-layout.test.tspassed.git diff --checkpassed.bun test apps/cli/test/commands/eval/artifact-writer.test.ts; it failed before running tests because@agentv/corecould not be resolved.bun test apps/cli/test/eval.integration.test.ts; it failed before running tests becauseexecacould not be resolved.bun installper repo instructions.Post-Deploy Monitoring & Validation
No production service monitoring is needed. After merge, validate by running a fresh eval and confirming
.agentv/results/<experiment>/<timestamp>/index.jsonlis the only new run manifest, with per-result sidecars resolved through row path fields and no target/model/variant/casesfolder layer.