fix(eval): reject per-case target selection - #1551
Merged
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
4cf921b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5bdc49c.agentv.pages.dev |
| Branch Preview URL: | https://hard-deprecate-per-case-targ.agentv.pages.dev |
christso
force-pushed
the
hard-deprecate-per-case-targets
branch
from
June 28, 2026 08:24
0660be1 to
4cf921b
Compare
christso
marked this pull request as ready for review
June 28, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authored eval YAML no longer supports target selection inside individual test-case
executionblocks. The test-case execution schema now omitstargetandtargets, and the parser/validator reject unsupported test execution keys through generic strictness instead of a bespoke field-specific deprecation path.Runtime matrix execution no longer reads
EvalTest.targets, so every selected suite/experiment/CLI target runs the same filtered case set rather than silently creating sparse per-case matrices. Promptfoo imports keep default provider filters at the suite target level and reject test-level provider filters because they would require unsupported per-case target selection.Docs, examples, the eval-writer guidance, and the generated schema reference now show target choice as runtime policy rather than test-case data.
Validation
bun install --frozen-lockfile(dependencies were absent in this isolated worktree; lockfile unchanged)bun --filter @agentv/core buildbun test packages/core/test/evaluation/matrix-targets.test.ts packages/core/test/evaluation/eval-inline-experiment.test.ts packages/core/test/evaluation/validation/eval-file-schema.test.ts packages/core/test/evaluation/validation/eval-validator.test.ts packages/core/test/evaluation/loaders/config-loader.test.ts apps/cli/src/commands/import/promptfoo.test.ts apps/cli/test/commands/eval/task-bundle.test.ts packages/core/test/evaluation/validation/eval-schema-sync.test.tsbun run typecheckbun run lintgit diff --checkPost-Deploy Monitoring & Validation
No additional operational monitoring required. This is local parser/validator/CLI behavior with no deployed runtime service; GitHub Actions are the merge gate, and failures in schema sync, core parser tests, CLI import tests, typecheck, or lint should block release.