DBDAART-17625#342
Open
fumanjie wants to merge 1 commit into
Open
Conversation
Remove DE_Runner dependence on state_code parameter. Dummy records limited to those with submtg_state_cd value in the set of unique submtg_state_cd values found among non-dummy records to satisfy DBDAART-15026.
fumanjie
requested review from
XiaoBarry,
a-pfeiffer and
alihashmi-wh
and removed request for
XiaoBarry,
a-pfeiffer and
alihashmi-wh
hls0231
previously approved these changes
Apr 8, 2026
hls0231
dismissed
their stale review
After further discussion, we want to keep the PR open to determine the correct behavior if a state sends no enrollment records for the time period - create dummy records or not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBDAART-17625 - Potential bug investigation - FTX dummy records in ADE
What is this and why are we doing it?
With the cutover to TAF v9.0, DBDAART-15026 called for the exclusion of dummy records created from claims, for states not involved in the ADE build. The mechanism by which this took place introduced an unforeseen dependency on the otherwise-unused state_code parameter of the DE_Runner: dummy records pulled from claims would be limited to those listed in state_code. This code removes said dependency, and uses the set of unique submtg_state_cd values among non-dummy records in the current build as the list of states from which to retain dummies.
What are the security implications from this change?
N/A
How did I test this?
Built test ADE using synthetic BSF containing states 41+42+66, and synthetic claims containing states 42+44+66, with both the old and new DE_Runner. state_code parameter submitted as "'41','44','66'.
Both versions produce ADE with non-dummies from 41+42+66, and dummies from 66.
The old code omits dummies from 42 (like it had been doing with CA), since it is not included in state_code, but includes 44.
The updated code includes dummies from 42 but omits 44 (due to the build including BSF non-dummies from 42 but not 44).
Should there be new or updated documentation for this change? (Be specific.)
Documentation handled in associated JIRA tickets
PR Checklist