Skip to content

DBDAART-4915 Replace setup.py with pyproject.toml#111

Open
RIE9-adhoc wants to merge 1 commit into
mainfrom
DBDAART-4915
Open

DBDAART-4915 Replace setup.py with pyproject.toml#111
RIE9-adhoc wants to merge 1 commit into
mainfrom
DBDAART-4915

Conversation

@RIE9-adhoc

Copy link
Copy Markdown
Contributor

What is this and why are we doing it?

This converts setup.py to use pyproject.toml. This also pins the Python version and all Python libraries used. This was loosely copied from https://github.com/Enterprise-CMCS/macdc-etl/blob/main/pyproject.toml.

What are the security implications from this change?

This PR pins all versions of Python libraries used in this project. The intent is to remove any implicit upgrades which could make the codebase unstable or introduce unwanted changes.

How did I test this?

https://cms-dataconnect.cloud.databricks.com/?o=667862292061707#job/312145567586946/run/1004710749795555
This job run specifies a whl file I uploaded. This whl file was created from this branch using: python -m build. I verified row counts here: https://cms-dataconnect.cloud.databricks.com/?o=667862292061707#notebook/1742384232055524/command/1742384232055531.

Should there be new or updated documentation for this change? (Be specific.)

The only things that should change from dev-related regular use cases are the command to build the whl file and the version naming scheme (which is now compliant with https://peps.python.org/pep-0440/). The code to produce TAF files has not changed.

PR Checklist

  • The JIRA ticket number and a short description is in the subject line
  • My code follows any applicable style guides
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant