DBDAART-4915 Replace setup.py with pyproject.toml#111
Open
RIE9-adhoc wants to merge 1 commit into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this and why are we doing it?
This converts setup.py to use pyproject.toml. This also pins the Python version and all Python libraries used. This was loosely copied from https://github.com/Enterprise-CMCS/macdc-etl/blob/main/pyproject.toml.
What are the security implications from this change?
This PR pins all versions of Python libraries used in this project. The intent is to remove any implicit upgrades which could make the codebase unstable or introduce unwanted changes.
How did I test this?
https://cms-dataconnect.cloud.databricks.com/?o=667862292061707#job/312145567586946/run/1004710749795555
This job run specifies a whl file I uploaded. This whl file was created from this branch using:
python -m build. I verified row counts here: https://cms-dataconnect.cloud.databricks.com/?o=667862292061707#notebook/1742384232055524/command/1742384232055531.Should there be new or updated documentation for this change? (Be specific.)
The only things that should change from dev-related regular use cases are the command to build the whl file and the version naming scheme (which is now compliant with https://peps.python.org/pep-0440/). The code to produce TAF files has not changed.
PR Checklist