Skip to content

Introduce WindFarmParameters and make types more consistent#14

Merged
Zetison merged 5 commits into
mainfrom
enhance/wind_parameters_and_misc
Jun 1, 2026
Merged

Introduce WindFarmParameters and make types more consistent#14
Zetison merged 5 commits into
mainfrom
enhance/wind_parameters_and_misc

Conversation

@Zetison

@Zetison Zetison commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Introduces WindFarmParameters more in line with PVParameters and also made the corresponding nodes more consistent.

… made the corresponding nodes more consistent [skip ci]
@Zetison Zetison requested a review from Copilot May 28, 2026 13:21
@Zetison Zetison self-assigned this May 28, 2026
@Zetison Zetison added the enhancement New feature or request label May 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces WindFarmParameters to centralize wind-farm sampling parameters similarly to PVParameters, updates the wind sampling constructor to consume the new parameter type, and adds validation/tests/docs for the new API.

Changes:

  • Added WindFarmParameters, to_dict(::WindFarmParameters), and lat/lon validation for parameter types.
  • Updated WindPower sampling constructor and tests to use WindFarmParameters and DateTime.
  • Updated exports, public docs, release notes, and formatting in related tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/datastructures.jl Adds wind parameter type, validation, conversion helper, and refactors sampling docs/signature.
src/EnergyModelsLanguageInterfaces.jl Exports the new parameter type and reorganizes exports.
docs/src/library/public.md Documents the new parameter type/helper and updated WindPower constructor signature.
test/test_windpower.jl Adds constructor and validation tests for WindFarmParameters.
test/test_PV.jl Adds invalid latitude/longitude tests for PVParameters.
test/utils.jl Updates wind test helper to use the new constructor and applies formatting changes.
test/test_checks.jl Applies formatting-only updates to test dictionaries.
NEWS.md Adds release note entry for WindFarmParameters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/datastructures.jl
Comment thread src/datastructures.jl
Comment thread src/datastructures.jl Outdated
Comment thread src/datastructures.jl Outdated
Zetison and others added 2 commits May 29, 2026 10:53
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread test/utils.jl Outdated
Comment thread docs/src/library/public.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Zetison Zetison requested a review from JulStraus May 29, 2026 09:53

@JulStraus JulStraus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to the docstrings for the Parameters. In addition, I am uncertain whether we should use the finite tests. Honestly speaking, I do not know how non finite numbers could be provided except for someone providing a value of NaN or Inf.

In this case, I would just let them run into problems with nondescriptive error messages as it is just plain stupid. ;)

Comment thread src/datastructures.jl Outdated
Comment thread src/datastructures.jl Outdated
Comment thread src/datastructures.jl
Comment thread test/test_checks.jl
Comment thread src/datastructures.jl Outdated

@Zetison Zetison left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added your suggestions

@Zetison Zetison requested a review from JulStraus May 29, 2026 12:14

@JulStraus JulStraus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Zetison Zetison merged commit b996107 into main Jun 1, 2026
9 of 13 checks passed
@Zetison Zetison deleted the enhance/wind_parameters_and_misc branch June 1, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants