Added functionality for adding additional plots#54
Open
Zetison wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for user-provided “additional plots” in the GUI, allowing plot series to be sourced from either in-memory DataFrames or CSV files and integrated into the “Available data” menu for plotting/normalization.
Changes:
- Adds
additional_plotskeyword toGUI(...), with validation and release-note documentation. - Extends available-data initialization to ingest additional plot data (from
DataFrame/CSV) and expose numeric columns as selectable plot containers. - Adds test coverage to load/compare additional plots from both
DataFrameand CSV inputs (and updates test dependencies/imports accordingly).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/setup_GUI.jl |
Adds additional_plots kwarg, validates inputs, and stores config in gui.vars. |
src/utils_GUI/GUI_utils.jl |
Implements ingestion of additional plot data, adds CSV reading helper, extends selection API, and refactors time-period dict logic. |
src/utils_GUI/results_axis_utils.jl |
Improves time-axis type detection for GlobalDataContainer backed by a DataFrame. |
test/test_results_IO.jl |
Adds an integration test validating additional plot data from both DataFrame and CSV sources. |
test/runtests.jl |
Imports CSV/DataFrames for the new tests. |
test/Project.toml |
Adds CSV/DataFrames as test dependencies. |
NEWS.md |
Notes the new “additional plots” functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the user to add additional plots from
DataFrames or CSV-files.