Skip to content

Update key diff logic #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TravisS25 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update key diff logic #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plugins/module_utils/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,14 @@ def diff_shared_keys(d1, d2):
"""
if not isinstance(d1, dict) or not isinstance(d2, dict):
return d1 != d2
shared_keys = set(d1.keys()) & set(d2.keys())

# If d2 contains any keys that d1 does not have, that's a difference
keys_d1 = set(d1.keys())
keys_d2 = set(d2.keys())
if keys_d2 - keys_d1:
return True

shared_keys = keys_d1 & keys_d2
for key in shared_keys:
v1 = d1[key]
v2 = d2[key]
Expand Down