Update bundled TkDND binaries to 2.10.1, add real Tcl 8.6 osx-arm64 b… - #18
Merged
Conversation
…uild Updates linux-x64(-tcl9), linux-arm64(-tcl9), win-x64(-tcl9), win-x86(-tcl9), and win-arm64 from TkDND 2.10.0 to 2.10.1, bringing in fixes for a GTK3 file-drop interop bug, a BadWindow crash on X11 drops, a Windows long-path truncation bug, an X11 pointer-grab break on virtual desktop switches, and intermittent drop failures on Wayland/XWayland. Also splits osx-arm64 into a real Tcl 8.6 build and a new osx-arm64-tcl9 folder. TkDND's macOS CI previously had no Tcl 8.6 build for arm64 at all, so osx-arm64 was silently serving a Tcl 9-linked binary to everyone, including Tcl 8.6 Python installs (the common case on Apple Silicon Macs), where it would fail to load. osx-arm64 is now genuinely Tcl 8.6, with Tcl 9 runtimes falling back to osx-arm64-tcl9 per TkinterDnD.py's existing version-detection logic. win-arm64 stays Tcl 9-linked (TkDND has no Tcl 8.6 Windows ARM64 build) and osx-x64 stays on its old 2.9.4 binary (no macOS x64 build exists in TkDND's CI at all) -- both documented gaps, not regressions from this change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
test_expected_version hardcoded the exact TkDND version string per platform, so it broke on every version bump for reasons unrelated to whether the binary actually works. test_version_is_set already covers the thing that matters (a version was loaded at all). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.6.1
- Updated TkDND binaries to 2.10.1 for linux-x64(-tcl9), linux-arm64(-tcl9),
win-x64(-tcl9), win-x86(-tcl9), win-arm64, and osx-arm64. This brings in
TkDND's Tcl 9 compatibility work plus fixes for: file drops being
ignored by GTK3 apps, a BadWindow crash on X11 drops, a Windows
long-path truncation bug, an X11 pointer-grab break on virtual desktop
switches, and intermittent drop failures on Wayland/XWayland.
- Split osx-arm64 into a real Tcl 8.6 build and a new osx-arm64-tcl9
folder. Previously osx-arm64 only ever shipped a Tcl 9-linked binary
(TkDND's macOS CI had no Tcl 8.6 build available), so Tcl 8.6 Python
installs on Apple Silicon silently got an incompatible library. Now
osx-arm64 is genuinely Tcl 8.6, and Tcl 9 runtimes fall back to the new
osx-arm64-tcl9 folder as intended.
- win-arm64 remains Tcl 9-linked (TkDND has no Tcl 8.6 Windows ARM64
build), and osx-x64 remains on its old 2.9.4 binary (no macOS x64
build exists in TkDND's CI at all) -- both unchanged from 0.6.0 aside
from win-arm64 picking up the 2.10.1 Tcl 9 refresh.