Allow user to choose the models for pickup items via their player options YAML#27
Open
Nystrata wants to merge 5 commits into
Open
Allow user to choose the models for pickup items via their player options YAML#27Nystrata wants to merge 5 commits into
Nystrata wants to merge 5 commits into
Conversation
…malPickupModel - Player options are now ProgressionPickupModel, UsefulPickupModel, NormalPickupModel - Correct "RandovaniaGamecube" to just "Gamecube"
hesto2
approved these changes
Feb 28, 2025
hesto2
left a comment
hesto2
left a comment
Collaborator
There was a problem hiding this comment.
Nice, I'll test this out this weekend but this looks solid. Thank you!
lilDavid
reviewed
Apr 24, 2025
Comment on lines
+331
to
+337
| class UsefulPickupModel(Choice): | ||
| """Choose a model for Useful or Trap item pickups""" | ||
| default = "Zoomer" | ||
| option_metroid = "Metroid" | ||
| option_zoomer= "Zoomer" | ||
| option_cog = "Cog" | ||
| option_gamecube = "GameCube" |
Contributor
There was a problem hiding this comment.
I'd like to see separate Useful and Trap options to give the player the choice to make trap pickups look like progression. (and IMO trap should take priority over useful)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds player options: ProgressionPickupModel, UsefulPickupModel, NormalPickupModel
Each has a choice of Metroid, Zoomer, Cog, or GameCube