Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the export logic in src/utils/ExportCanvas.tsx to disable plot animations during the export process. The feedback suggests that the animation state should be captured and restored after the export completes to maintain the user's UI settings, consistent with how other export parameters are managed.
| } | ||
| SetCamera(true); | ||
| if (animate){ | ||
| usePlotStore.setState({animate:false}) // Disable animation if currently active |
There was a problem hiding this comment.
While disabling the plot animation during export is necessary to prevent conflicts with the manual frame-stepping logic, the original state of animate should be captured and restored once the export process completes.
Currently, if a user has animation enabled in the UI, it will remain disabled after the export finishes. This should be handled similarly to how quality (line 252/487) and DPR (line 253/488) are managed: capture the original value at the start of the useEffect and restore it in both the Animate().then() block and the static export else block.
| usePlotStore.setState({animate:false}) // Disable animation if currently active | |
| usePlotStore.setState({ animate: false }) // Disable animation if currently active |
Quick oneliner to turn off animation in case it is on during export
closes #638