Conversation
test reading data with spaces
…t data into blocks and associates the config values with the standards.
This remedies the decision made in #50, because test files should never include any library calls!
- test output summary file: on some systems, Sys.time returns fractional seconds; wrapping its output in format() limits accuarcy to integer seconds so that the corresponding unit test passes on these systems. - test calibration procedures: it is unclear why some p- and r-squared values output from stats::lm have changed, causing tests, which have expectations hard-coded based on manual calculations of the respective values, starting to fail. I assume the problem is related to the R major version update >4. The respective tests have been updated such that they now calculate the expected values themselves automatically, so that the tests should pass independent of the system or R version used for running these tests.
- Mainly updates from e248506.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be time to merge the re-written piccr package on master.
I created the new branch
legacy-pkg-devthat contains what is currently on master so that we can easily access that version.Cpt-Picarr uses the piccr branch dev. Therefore if we merge this PR, we need to make some changes to Cpt.Picarr. I have opened the PR EarthSystemDiagnostics/cpt-picarr#62 that should be merged right after this PR.
Note that #33 should be merged before this PR is merged.