feat: replace bundled skills with single using-skillshub default - #74
Conversation
Adds plan for removing the 13 bundled skills under skills/ while keeping the directory and default-tap wiring intact, in preparation for a new skill set.
Empties the default EYH0602/skillshub tap of its 13 prior bundled skills (analyze-ci, docs-review, docstring, fuzzing, github-actions-templates, paper-polish, python-packaging, read-repo-references, senior-data-scientist, temporal-python-testing, testing-python, uv-package-manager, write-unit-tests) and ships a single new skill, using-skillshub, that teaches AI coding agents how to drive the skillshub CLI: tap-install-link mental model, a command decision table, common workflows, and SKILL.md authoring guidance. Bundles cli-reference.md and architecture.md as references so the skill is self-contained after install. Updates README.md, CLAUDE.md, AGENTS.md, and src/cli.rs doc-comment examples to reference EYH0602/skillshub/using-skillshub instead of a non-existent code-reviewer, so copy-pasting examples actually works against the default tap. CHANGELOG records additions, removals, and example updates. Implementation plan in docs/plans/ updated with final design.
fenfenai
left a comment
There was a problem hiding this comment.
Review summary
Reviewed the substantive changes (the new using-skillshub skill, bundled references, src/cli.rs doc-comment substitutions, and the README/CLAUDE.md/AGENTS.md/CHANGELOG updates). Bulk skill removals were not reviewed line-by-line — they're intentional scope per the plan.
The load-bearing factual claims in SKILL.md were spot-checked against src/registry/skill.rs, src/registry/git.rs, src/agent.rs, src/cli.rs, and src/commands/clean.rs and all hold up: the @commit rejection, the 17-agent enumeration (Kiro→steering, the rest→skills), the three-location mental model, skillshub clean all semantics, and the gist-vs-tap split are all accurate.
Two inline findings + one PR-description-level note below.
Important (confidence 90-100)
-
skills/using-skillshub/references/cli-reference.md:13(95) — internal contradiction with SKILL.md and the source code. The bundled reference advertisesskillshub install <owner/repo/skill>[@commit]as supported syntax, but SKILL.md correctly warns that@commitis rejected for non-gist taps, andsrc/registry/skill.rs:129-131hard-errors withPinned commits are not supported for git-based taps.An agent loading both files into context will pick up the syntax from the reference and confidently suggest a command that always fails. Either drop[@commit]from this line, or annotate it as gist-only. -
docs/plans/2026-05-07-empty-default-tap.md:4(90) —**Status**: Draft — awaiting reviewis stale: the plan is fully implemented by commit 7cce504 in this same PR. CLAUDE.md says: "After the plan is fully implemented, rewrite it as a design doc indocs/, and remove it fromplans/." At minimum flip the status toImplemented; ideally promote the file to a design doc (e.g.docs/empty-default-tap.md) and drop it fromdocs/plans/.
Minor (confidence 75-89)
- PR description test plan (85) — only 2 of 7 items are checked. The 5 unchecked items (
installresolves,infoshows metadata,linksymlinks the skill, bundledreferences/ride along after install, README Quick Start examples actually install) cover precisely the behavior this PR changes — andcargo testdoesn't exercise any of them because the test fixtures don't read the realskills/directory. Worth running them locally and ticking the boxes (or noting why they're being deferred) before merge.
Positive observations
- Plan was committed before the implementation (
f67bd67then7cce504) — good process. - The
code-reviewer→using-skillshubsubstitution is consistent acrosssrc/cli.rs, README, CLAUDE.md, AGENTS.md, and CHANGELOG. No stale references to the 13 removed skills remain in source or docs. - 17-agent list is identical across
src/agent.rs::KNOWN_AGENTS, SKILL.md, the bundledarchitecture.md, and README — no drift. - SKILL.md
descriptionis a strong trigger string (covers both what and when, with concrete trigger phrases). references/cli-reference.mdandreferences/architecture.mdare byte-identical copies of the canonical docs at PR-head — the acknowledged drift tradeoff hasn't materialized yet.
Cuts a 1.1.0 release: the new bundled `using-skillshub` skill and the default-tap reset are additive feature work over a stable CLI surface, so a minor bump fits SemVer cleanly. Backfills the previously missing 1.0.1, 1.0.2, and 1.0.3 entries (UTF-8 truncate fix, OpenCode path fix, Kiro CLI + 6 trending agents) so the changelog matches what actually shipped on crates.io.
|
Addressing the three findings. 1. 2. 3. PR description test plan (85) — already addressed: all 7 boxes are currently ticked in the PR body, including the 5 the review flagged ( Build still passes after the doc changes ( |
- Drop misleading [@commit] from install syntax in both cli-reference.md files. The bracket syntax is rejected for non-gist taps and ignored for the bundled default tap; gists are reached via `skillshub add <gist-url>`, not this install form. The gist-only nuance stays in SKILL.md. - Promote 2026-05-07-empty-default-tap plan to docs/empty-default-tap.md as a concise design doc per the CLAUDE.md "rewrite as design doc in docs/, remove from plans/" rule.
fenfenai
left a comment
There was a problem hiding this comment.
Re-review: all findings addressed
Verified the two new commits (3110b02 version bump, 7724de0 doc fixes) at head 7724de0.
Resolved
@commitcontradiction — Fixed in bothskills/using-skillshub/references/cli-reference.md:13and the canonicaldocs/cli-reference.md:13. Both now showskillshub install <owner/repo/skill>with no bracket. Consistent withsrc/registry/skill.rs:130and the SKILL.md warning.- Plan status — Cleanly handled per CLAUDE.md:
docs/plans/2026-05-07-empty-default-tap.mddeleted, replaced by a concise design doc atdocs/empty-default-tap.mdwith**Status**: Implemented. The new doc preserves the load-bearing decisions (bundle-references-inside-the-skill, out-of-scope invariants) without retaining the implementation-step noise. - Test plan — All 7 items now checked.
New commits also reviewed
Cargo.toml1.0.3 → 1.1.0: minor bump is reasonable — the binary's CLI surface is unchanged; only the default-tap contents changed.Cargo.lockupdated to match.- CHANGELOG:
[Unreleased]retitled to[1.1.0] - 2026-05-07and backfilled with[1.0.1],[1.0.2],[1.0.3]entries. The backfills accurately match the commit history (multi-byte UTF-8 fix → 1.0.1, OpenCode path fix → 1.0.2, Kiro + 6 agents → 1.0.3). - Design doc:
docs/empty-default-tap.mdis well-scoped — rationale + key decisions + scope boundaries, no leftover implementation steps.
Resolving both inline threads. Approving.
Reconcile concurrent version bumps: main shipped 1.0.4 (GH_TOKEN support, #73) while this branch bumped to 1.1.0 for the using-skillshub default. Keep 1.1.0 (feature > patch under semver) and slot main's 1.0.4 entry between 1.1.0 and 1.0.3 in CHANGELOG.
Summary
skills/(analyze-ci, docs-review, docstring, fuzzing, github-actions-templates, paper-polish, python-packaging, read-repo-references, senior-data-scientist, temporal-python-testing, testing-python, uv-package-manager, write-unit-tests). Default tap is intentionally being curated down to a single focused skill.using-skillshub, that teaches AI coding agents how to drive theskillshubCLI: tap → install → link mental model, a command decision table, common workflows, and SKILL.md authoring guidance. Bundlescli-reference.mdandarchitecture.mdas references so it stays self-contained afterskillshub install.src/cli.rsdoc-comment examples so they referenceEYH0602/skillshub/using-skillshub(which now exists in this tap) instead ofcode-reviewer(which never did). Copy-pasted examples now work against the default tap out of the box.Test plan
cargo buildpassescargo testpasses (43 tests across both integration suites)cargo run -- install EYH0602/skillshub/using-skillshubresolves and installs against this branchcargo run -- info EYH0602/skillshub/using-skillshubshows the new skill metadataskillshub linkcreates~/.claude/skills/using-skillshubsymlink after installreferences/cli-reference.mdandreferences/architecture.mdride along with the install