Skip to content

feat: replace bundled skills with single using-skillshub default - #74

Merged
EYH0602 merged 5 commits into
mainfrom
worktree-cosmic-popping-pebble
May 14, 2026
Merged

feat: replace bundled skills with single using-skillshub default#74
EYH0602 merged 5 commits into
mainfrom
worktree-cosmic-popping-pebble

Conversation

@EYH0602

@EYH0602 EYH0602 commented May 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove 13 previously bundled skills from skills/ (analyze-ci, docs-review, docstring, fuzzing, github-actions-templates, paper-polish, python-packaging, read-repo-references, senior-data-scientist, temporal-python-testing, testing-python, uv-package-manager, write-unit-tests). Default tap is intentionally being curated down to a single focused skill.
  • Add a new bundled skill, using-skillshub, that teaches AI coding agents how to drive the skillshub CLI: tap → install → link mental model, a command decision table, common workflows, and SKILL.md authoring guidance. Bundles cli-reference.md and architecture.md as references so it stays self-contained after skillshub install.
  • Update README, CLAUDE.md, AGENTS.md, and src/cli.rs doc-comment examples so they reference EYH0602/skillshub/using-skillshub (which now exists in this tap) instead of code-reviewer (which never did). Copy-pasted examples now work against the default tap out of the box.
  • CHANGELOG records additions, removals, and example updates.

Test plan

  • cargo build passes
  • cargo test passes (43 tests across both integration suites)
  • cargo run -- install EYH0602/skillshub/using-skillshub resolves and installs against this branch
  • cargo run -- info EYH0602/skillshub/using-skillshub shows the new skill metadata
  • skillshub link creates ~/.claude/skills/using-skillshub symlink after install
  • Bundled references/cli-reference.md and references/architecture.md ride along with the install
  • Spot-check README's Quick Start examples actually install something from the default tap

EYH0602 added 2 commits May 7, 2026 21:56
Adds plan for removing the 13 bundled skills under skills/ while keeping
the directory and default-tap wiring intact, in preparation for a new
skill set.
Empties the default EYH0602/skillshub tap of its 13 prior bundled
skills (analyze-ci, docs-review, docstring, fuzzing,
github-actions-templates, paper-polish, python-packaging,
read-repo-references, senior-data-scientist, temporal-python-testing,
testing-python, uv-package-manager, write-unit-tests) and ships a
single new skill, using-skillshub, that teaches AI coding agents how
to drive the skillshub CLI: tap-install-link mental model, a command
decision table, common workflows, and SKILL.md authoring guidance.
Bundles cli-reference.md and architecture.md as references so the
skill is self-contained after install.

Updates README.md, CLAUDE.md, AGENTS.md, and src/cli.rs doc-comment
examples to reference EYH0602/skillshub/using-skillshub instead of a
non-existent code-reviewer, so copy-pasting examples actually works
against the default tap. CHANGELOG records additions, removals, and
example updates. Implementation plan in docs/plans/ updated with
final design.

@fenfenai fenfenai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Reviewed the substantive changes (the new using-skillshub skill, bundled references, src/cli.rs doc-comment substitutions, and the README/CLAUDE.md/AGENTS.md/CHANGELOG updates). Bulk skill removals were not reviewed line-by-line — they're intentional scope per the plan.

The load-bearing factual claims in SKILL.md were spot-checked against src/registry/skill.rs, src/registry/git.rs, src/agent.rs, src/cli.rs, and src/commands/clean.rs and all hold up: the @commit rejection, the 17-agent enumeration (Kiro→steering, the rest→skills), the three-location mental model, skillshub clean all semantics, and the gist-vs-tap split are all accurate.

Two inline findings + one PR-description-level note below.

Important (confidence 90-100)

  1. skills/using-skillshub/references/cli-reference.md:13 (95) — internal contradiction with SKILL.md and the source code. The bundled reference advertises skillshub install <owner/repo/skill>[@commit] as supported syntax, but SKILL.md correctly warns that @commit is rejected for non-gist taps, and src/registry/skill.rs:129-131 hard-errors with Pinned commits are not supported for git-based taps. An agent loading both files into context will pick up the syntax from the reference and confidently suggest a command that always fails. Either drop [@commit] from this line, or annotate it as gist-only.

  2. docs/plans/2026-05-07-empty-default-tap.md:4 (90) — **Status**: Draft — awaiting review is stale: the plan is fully implemented by commit 7cce504 in this same PR. CLAUDE.md says: "After the plan is fully implemented, rewrite it as a design doc in docs/, and remove it from plans/." At minimum flip the status to Implemented; ideally promote the file to a design doc (e.g. docs/empty-default-tap.md) and drop it from docs/plans/.

Minor (confidence 75-89)

  1. PR description test plan (85) — only 2 of 7 items are checked. The 5 unchecked items (install resolves, info shows metadata, link symlinks the skill, bundled references/ ride along after install, README Quick Start examples actually install) cover precisely the behavior this PR changes — and cargo test doesn't exercise any of them because the test fixtures don't read the real skills/ directory. Worth running them locally and ticking the boxes (or noting why they're being deferred) before merge.

Positive observations

  • Plan was committed before the implementation (f67bd67 then 7cce504) — good process.
  • The code-reviewerusing-skillshub substitution is consistent across src/cli.rs, README, CLAUDE.md, AGENTS.md, and CHANGELOG. No stale references to the 13 removed skills remain in source or docs.
  • 17-agent list is identical across src/agent.rs::KNOWN_AGENTS, SKILL.md, the bundled architecture.md, and README — no drift.
  • SKILL.md description is a strong trigger string (covers both what and when, with concrete trigger phrases).
  • references/cli-reference.md and references/architecture.md are byte-identical copies of the canonical docs at PR-head — the acknowledged drift tradeoff hasn't materialized yet.

Comment thread skills/using-skillshub/references/cli-reference.md Outdated
Comment thread docs/plans/2026-05-07-empty-default-tap.md Outdated
Cuts a 1.1.0 release: the new bundled `using-skillshub` skill and the
default-tap reset are additive feature work over a stable CLI surface,
so a minor bump fits SemVer cleanly. Backfills the previously missing
1.0.1, 1.0.2, and 1.0.3 entries (UTF-8 truncate fix, OpenCode path
fix, Kiro CLI + 6 trending agents) so the changelog matches what
actually shipped on crates.io.
@EYH0602

EYH0602 commented May 8, 2026

Copy link
Copy Markdown
Owner Author

Addressing the three findings.

1. cli-reference.md:13 [@commit] contradiction (95) — fixed in both bundled and canonical files (see thread reply). Removed the bracket syntax rather than annotating it gist-only, since gists are installed via skillshub add <gist-url> and never via this install <owner/repo/skill> form. The SKILL.md warning at lines 197-199 already covers the nuance for agents.

2. docs/plans/2026-05-07-empty-default-tap.md stale status (90) — fixed by promoting to docs/empty-default-tap.md (concise design doc) and removing the plan, per the explicit CLAUDE.md rule. See thread reply.

3. PR description test plan (85) — already addressed: all 7 boxes are currently ticked in the PR body, including the 5 the review flagged (install resolves, info shows metadata, link symlinks, bundled references/ ride along, README Quick Start examples). The review must have rendered against an earlier revision of the description.

Build still passes after the doc changes (cargo build); no source code touched. Will let the human commit.

- Drop misleading [@commit] from install syntax in both cli-reference.md
  files. The bracket syntax is rejected for non-gist taps and ignored for
  the bundled default tap; gists are reached via `skillshub add <gist-url>`,
  not this install form. The gist-only nuance stays in SKILL.md.
- Promote 2026-05-07-empty-default-tap plan to docs/empty-default-tap.md
  as a concise design doc per the CLAUDE.md "rewrite as design doc in
  docs/, remove from plans/" rule.

@fenfenai fenfenai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: all findings addressed

Verified the two new commits (3110b02 version bump, 7724de0 doc fixes) at head 7724de0.

Resolved

  1. @commit contradiction — Fixed in both skills/using-skillshub/references/cli-reference.md:13 and the canonical docs/cli-reference.md:13. Both now show skillshub install <owner/repo/skill> with no bracket. Consistent with src/registry/skill.rs:130 and the SKILL.md warning.
  2. Plan status — Cleanly handled per CLAUDE.md: docs/plans/2026-05-07-empty-default-tap.md deleted, replaced by a concise design doc at docs/empty-default-tap.md with **Status**: Implemented. The new doc preserves the load-bearing decisions (bundle-references-inside-the-skill, out-of-scope invariants) without retaining the implementation-step noise.
  3. Test plan — All 7 items now checked.

New commits also reviewed

  • Cargo.toml 1.0.3 → 1.1.0: minor bump is reasonable — the binary's CLI surface is unchanged; only the default-tap contents changed. Cargo.lock updated to match.
  • CHANGELOG: [Unreleased] retitled to [1.1.0] - 2026-05-07 and backfilled with [1.0.1], [1.0.2], [1.0.3] entries. The backfills accurately match the commit history (multi-byte UTF-8 fix → 1.0.1, OpenCode path fix → 1.0.2, Kiro + 6 agents → 1.0.3).
  • Design doc: docs/empty-default-tap.md is well-scoped — rationale + key decisions + scope boundaries, no leftover implementation steps.

Resolving both inline threads. Approving.

Reconcile concurrent version bumps: main shipped 1.0.4 (GH_TOKEN
support, #73) while this branch bumped to 1.1.0 for the using-skillshub
default. Keep 1.1.0 (feature > patch under semver) and slot main's
1.0.4 entry between 1.1.0 and 1.0.3 in CHANGELOG.
@EYH0602
EYH0602 merged commit c08df09 into main May 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants