fix: clean up theme matchMedia listener to prevent leak#125
Merged
Conversation
Contributor
Author
|
Heads up: the failing Frontend CI check is unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
changelistener on thematchMedia("(prefers-color-scheme: dark)")query in
themeStore.tswas added but never removed, leaking the listener.How
Extracted the handler and the MediaQueryList into named references, and
added an exported
cleanupThemeListener()to allow proper removal.Behavior is unchanged.
Testing
Added a unit test verifying
cleanupThemeListener()callsremoveEventListenerwith the same handler. All themeStore tests pass(11/11) and
type-checkis clean.Closes #117