Allow date-filtered order additions across routes - #170
Merged
Conversation
Keep invalid route additions blocked while moving date scope into the Add orders dialog as an operator-controlled filter. Constraint: Shopify order data remains read-only and Route membership persists only through the existing CLEVER route-group boundary. Rejected: Reusing the entire Orders filter panel | It is tightly coupled to Orders URL and pagination state; this dialog only needs order and delivery dates. Confidence: high Scope-risk: moderate Directive: Preserve the unplanned, geocoded, non-cancelled, non-delivered eligibility gate when expanding dialog filters. Tested: npm test; npm run build; npm run typecheck; git diff --check Not-tested: Live embedded Shopify interaction before deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation