Explain locked route actions instead of failing silently - #166
Merged
Conversation
Constraint: Completed and active routes remain immutable for stop membership changes. Rejected: Allowing completed routes to add or reorder stops | would weaken route execution safeguards. Confidence: high Scope-risk: narrow Directive: Keep completed-route actions explanatory unless the route lifecycle policy is explicitly changed. Tested: npm test; npm run build; npm run typecheck; npm run check:public-urls Not-tested: Authenticated Ready-route browser interaction before deployment
OziinG
marked this pull request as ready for review
August 6, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The reported route was Completed. Both controls were natively disabled, so clicks produced no feedback and looked broken. The empty-candidate branch also depended on a modal invocation that was not reliable in this route surface.
Validation
npm test— 483 passednpm run buildnpm run typechecknpm run check:public-urls