Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@ updates:
cooldown:
default-days: 7
open-pull-requests-limit: 5
# @playwright/test 1.61 rewrote its config loader to call
# `require(..., {conditions})` and to return module sources from an ESM
# `load` hook. Yarn PnP supports neither, so every version past 1.60
# dies before the first test file is collected. Held back until PnP
# catches up or the frontend moves off it.
ignore:
- dependency-name: "@playwright/test"
versions: [ ">= 1.61" ]
groups:
frontend:
applies-to: version-updates
Expand Down
2 changes: 1 addition & 1 deletion services/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@eslint/js": "^10.0.1",
"@hey-api/openapi-ts": "0.99.0",
"@originjs/vite-plugin-commonjs": "^1.0.3",
"@playwright/test": "1.60.0",
"@playwright/test": "1.63.0",
"@types/luxon": "^3.7.5",
"@types/node": "^26.2.0",
"@types/webfontloader": "^1.6.38",
Expand Down
9 changes: 2 additions & 7 deletions services/frontend/tests/e2e/board-slice-open.motion.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,8 @@ test.describe("a member's slice opening on a phone", () => {

test.describe("a member's slice opening for a visitor who asked for less motion", () => {
test("clamps both movements to the ceiling the island allows", async ({page}) => {
/*
* Asked of the page rather than declared as an option, which is what the season spec next
* door does and for the same reason: on Playwright 1.60 `use.reducedMotion` does not reach
* the page at all, so `matchMedia` answers false however the option is set — #852. A test of
* what a visitor with the preference gets has to actually be one, so it says so here. Once
* #852 is fixed this line is what should go.
*/
// Asked of the page rather than taken from the project: this file runs in the motion
// project, which is the one project that asks for no preference at all.
await page.emulateMedia({reducedMotion: "reduce"})
const watched = await boardOnAPhone(page)

Expand Down
6 changes: 2 additions & 4 deletions services/frontend/tests/e2e/boards-swipe.motion.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,8 @@ test.describe("dragging the board page", () => {
/**
* What a visitor who asked for reduced motion gets, which is the gesture without its tails.
*
* The preference is emulated for this test rather than taken from the project, because
* `use.reducedMotion` does not reach the page on Playwright 1.60 — #852 — so every
* "deterministic" project in this suite is in fact running with full motion. The same line and
* the same reasoning are in `esports-season-on-show.spec.ts`; when #852 is fixed, both go.
* The preference is emulated for this test rather than taken from the project: this file runs
* in the motion project, which is the one project that asks for no preference at all.
*
* The durations are read off the animations themselves rather than timed with a clock. Eight
* workers share four vCPUs here, so a wall-clock measurement of "it settled quickly" is a
Expand Down
10 changes: 1 addition & 9 deletions services/frontend/tests/e2e/esports-season-on-show.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,7 @@ test.describe("the season a page opens on", () => {
})

test("crosses the seasons over rather than travelling, for a visitor who asked for less motion", async ({page}) => {
// Asked for here rather than left to the project.
//
// `use.reducedMotion: "reduce"` is set on every project but the motion one, and on
// Playwright 1.60 it does not reach the page: `matchMedia("(prefers-reduced-motion:
// reduce)")` answers false throughout the deterministic suites. That is a fault in the
// harness rather than in this behaviour — #852 — and it is not this spec's to fix, but a
// test of what a visitor with the preference gets has to actually be one. Once #852 is
// fixed this line is what should go.
await page.emulateMedia({reducedMotion: "reduce"})
// The preference comes from the project, which every project but the motion one sets.
await installApiMocks(page)

await page.goto("/esports/competitive-scene")
Expand Down
5 changes: 1 addition & 4 deletions services/frontend/tests/e2e/membership.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,9 @@ test.describe("membership page", () => {
* The one moving thing on the page, for a visitor who asked for less of it: the words are
* simply there, at rest, rather than arriving.
*
* The preference is emulated here rather than left to the project: `use.reducedMotion` does
* not reach the page on Playwright 1.60 (#852), so a spec that assumes it is asserting the
* unreduced path under a reduced name.
* The preference comes from the project, which every project but the motion one sets.
*/
test("does not animate the pitch in for a visitor who asked for less motion", async ({page}) => {
await page.emulateMedia({reducedMotion: "reduce"})
await installApiMocks(page)
await page.goto("/membership")

Expand Down
53 changes: 15 additions & 38 deletions services/frontend/yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading