Skip to content

Dev#61

Merged
E-O-Conchas merged 5 commits into
mainfrom
dev
Mar 23, 2026
Merged

Dev#61
E-O-Conchas merged 5 commits into
mainfrom
dev

Conversation

@E-O-Conchas

Copy link
Copy Markdown
Contributor

This PR regenerates README.md after the README.Rmd update so the rendered repository README on GitHub reflects the Bioconductor installation change.

@E-O-Conchas
E-O-Conchas merged commit 6796a3b into main Mar 23, 2026
1 check passed
@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
R/ebv_download.R 0.00% <ø> (-77.47%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c354db460

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

expect_equal(data[data$id==28, 'doi'], '10.25829/bk5g87')
})
skip_if_portal_tests_unavailable <- function() {
testthat::skip_on_ci()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep download tests enabled when CI has portal access

skip_if_portal_tests_unavailable() now calls testthat::skip_on_ci() unconditionally, so every ebv_download test is skipped in CI runs (the R job in .github/workflows/R.yaml is where these checks run). This removes automated coverage for the package's main download paths (numeric ID, DOI, title lookup), allowing regressions to merge undetected even when the EBV API is reachable; the skip should be limited to offline/unreachable conditions instead of all CI environments.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant