Fix #56: add Bioconductor version install step to README - #59
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd676669eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect_equal(data[data$id==28, 'doi'], '10.25829/bk5g87') | ||
| }) | ||
| skip_if_portal_tests_unavailable <- function() { | ||
| testthat::skip_on_ci() |
There was a problem hiding this comment.
Avoid unconditionally skipping portal tests in CI
Because each test_that now calls skip_if_portal_tests_unavailable(), the first statement testthat::skip_on_ci() causes all download tests in this file to be skipped in GitHub Actions (the R.yaml workflow runs tests in a CI environment). This means ebv_download no longer gets any CI verification, so regressions in the package’s core download paths can merge undetected even when the portal is reachable.
Useful? React with 👍 / 👎.
Fixes #56