fix(core): harden ledger concurrency for production gate Q4 - #8
Open
Dukeabaddon wants to merge 5 commits into
Open
fix(core): harden ledger concurrency for production gate Q4#8Dukeabaddon wants to merge 5 commits into
Dukeabaddon wants to merge 5 commits into
Conversation
Replace the fixed 100ms worker sleep with a SharedArrayBuffer barrier so all workers reach contention before the test lock releases. Recover from concurrent UNIQUE inserts in appendSupportingArtifact by reconciling the existing row instead of surfacing raw SQLite errors.
3 tasks
Relocate blocked-sqlite-workers into packages/core/src/testing so tsc -b includes them. Exclude the worker entry from compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/helpers/blocked-sqlite-workers.tsand reuse it fromledger.test.tsandpipeline.e2e.test.ts.UNIQUEinserts inappendSupportingArtifactby reconciling the existing row (idempotent replay or deterministic conflict) instead of surfacing raw SQLite errors.Dependency note
Branched from latest
main(9a92922). Phase 3 controller split (feat/production-phase-3a-evidence,feat/production-phase-3b-cross-artifact) is not merged yet; this PR is independent and targetsmaindirectly per the production plan.Test plan
npm test -- packages/core/src/ledger.test.ts packages/mcp/src/pipeline.e2e.test.tsnpm test -- --coveragethree consecutive green runsnpm test(401/401)Closes PRODUCTION_GATE Q4 (coverage run stable with ledger concurrency).