refactor(core): extract work-plan and permission-trace validators (phase 3c) - #10
Merged
Merged
Conversation
…ase 3c) Move WorkPlan submission validation, scoped work-order checks, and permission trace helpers out of controller.ts into dedicated modules without changing the RunController public API.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controller/work-plan-validator.tsPermissionAuthorizationError,tracePermissionDecision, and work-result permission trace events intocontroller/permission-trace.tsRunControllerfacade unchangedTest plan
npm test -- packages/core test/full-flow-conformance.test.tsnpm run format:checkcontroller.tsreduced from 4234 to 3646 lines