Update Springboot to 4.1.0 and improve nodeinfo animation#491
Conversation
WalkthroughNodeInfoController now embeds a SideBar component with expand/collapse/toggle methods and a close button, replacing direct visibility toggling. PluginsController delegates info-pane display to these new methods. Corresponding FXML layouts (NodeInfoView, PluginsView) are restructured to support the sidebar and close button. ChangesSidebar-based node info panel
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant PluginsController
participant NodeInfoController
participant SideBar
User->>PluginsController: select plugin/toggle info pane
PluginsController->>NodeInfoController: show() / hide() / toggleVisibility()
NodeInfoController->>SideBar: expand() / collapse() / toggle()
User->>NodeInfoController: click closeButton
NodeInfoController->>SideBar: collapse()
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@owlplug-client/src/main/java/com/owlplug/plugin/controllers/NodeInfoController.java`:
- Around line 73-79: The close button visibility is currently tied only to
pluginInfoView in NodeInfoController, so it disappears whenever
directoryInfoView, symlinkInfoView, or componentInfoView is shown. Update the
closeButton.visibleProperty binding in setNode() to reflect whether any of the
four info views is visible, and keep the existing mutual-exclusion logic in sync
so the button remains available for all node types.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5cea5069-a01c-4937-be67-58b628bea9f1
⛔ Files ignored due to path filters (1)
owlplug-client/pom.xmlis excluded by!**/*.xml
📒 Files selected for processing (4)
owlplug-client/src/main/java/com/owlplug/plugin/controllers/NodeInfoController.javaowlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginsController.javaowlplug-client/src/main/resources/fxml/plugins/NodeInfoView.fxmlowlplug-client/src/main/resources/fxml/plugins/PluginsView.fxml
No description provided.