Various v2 theme cleanup and adjust

[DropSnorz]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3544a486-54f5-4f9f-95fa-f2230a4bb3c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

Migrates CSS color references from legacy named variables (text-color, disabled-color, danger-color, etc.) to AtlantaFX/owlplug theme tokens (-owlplug-color-text, -color-fg-muted, -color-danger-emphasis, etc.) across the stylesheet, dark theme SCSS color ramps, FXML views, and Java controller. Also removes unused task icon fields and adjusts card style classes and layout padding.

Changes

Theme variable migration and UI style cleanup

Layer / File(s)	Summary
Dark theme warning/danger color ramps owlplug-theme/src/main/scss/owlplug-dark.scss	Replaces $warning-0…9 and $danger-0…9 SCSS color scale values with new yellow-shifted warning and cooler crimson danger ramps.
CSS root variable and label/text color token migration owlplug-client/src/main/resources/owlplug.css	Replaces legacy text-color, disabled-color, danger-color variables with -owlplug-color-text, -color-fg-muted, -color-danger-emphasis tokens across .label, .text-*, heading, chip, autocomplete, status icon, shape state, button/hyperlink, chart, and preloader rules. Removes capitalized Label selector in favor of .label. Removes .hyperlink-web:visited rule. Switches axis-line from visibility: hidden to -fx-opacity: 0.
pane-card and dashboard-card style and FXML updates owlplug-client/src/main/resources/owlplug.css, owlplug-client/src/main/resources/fxml/HomeView.fxml	Rewrites pane-card CSS to use -color-border-default for border; switches setupPane and storage VBox in HomeView.fxml from pane-card to dashboard-card.
Controller and FXML cleanup owlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java, owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.java, owlplug-client/src/main/resources/fxml/HomeView.fxml, owlplug-client/src/main/resources/fxml/projects/ProjectsView.fxml	Updates PluginPathFragmentController.refresh() to use -color-fg-muted/-color-danger-emphasis for directory status colors. Replaces ImageView cross icon with FontIcon in HomeView.fxml. Removes left-padding from ProjectsView.fxml right pane. Removes four unused task icon fields from ApplicationDefaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

• DropSnorz/OwlPlug#301: Modifies overlapping CSS selectors (.label-*, .pane-card, chart/scroll styles) in the same owlplug.css stylesheet.
• DropSnorz/OwlPlug#387: Modifies PluginPathFragmentController.refresh() directory status indicator logic in the same code path.
• DropSnorz/OwlPlug#479: AtlantaFX theme migration that aligns with the -color-* emphasis/fg-muted variable adoption in this PR.

Suggested labels

Status: In Progress

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is related to the theme/CSS cleanup, but it is too vague to clearly convey the main change.	Use a specific title like "Update v2 theme colors, CSS cleanup, and remove unused task icons".
Description check	❓ Inconclusive	No description was provided, so the PR intent cannot be assessed from the description.	Add a brief description summarizing the styling, color, and icon cleanup changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/theme-adjust

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[DropSnorz]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@owlplug-client/src/main/resources/fxml/HomeView.fxml`:
- Line 186: The unresolved tile’s alert icon is missing the warning styling and
fixed size that the old asset provided. Update the FontIcon in HomeView.fxml so
it still reads as a danger/alert indicator and matches the neighboring stat icon
sizing, using the existing icon element and its style/size properties rather
than leaving it unstyled.

In `@owlplug-client/src/main/resources/owlplug.css`:
- Line 51: There is an unnecessary blank line before the `-owlplug-color-text`
declaration in the stylesheet block; move `-owlplug-color-text` up to sit
directly with the surrounding custom properties in `owlplug.css` so the block
matches the expected declaration order and passes Stylelint.
- Around line 373-377: Keep the .pane-card surface styling intact in owlplug.css
for now, because multiple views still rely on it. Restore or preserve the
background and radius styling in the .pane-card rule used by
PluginInfoView.fxml, ProjectInfoView.fxml, ComponentInfoView.fxml,
PackageInfoView.fxml, WelcomeView.fxml, SymlinkInfoView.fxml, and
DirectoryInfoView.fxml, and only remove these styles after all of those
consumers have been migrated.

In `@owlplug-theme/src/main/scss/owlplug-dark.scss`:
- Around line 65-75: The danger palette needs to keep the foreground swatch
readable on the dark theme canvas, since $danger-4 currently feeds $danger-fg
and is too low-contrast for text/icons. Update the danger scale in
owlplug-dark.scss by making $danger-4 lighter, or adjust the $danger-fg
assignment to use a lighter danger stop while keeping the rest of the palette
intact. Use the $danger-4 and $danger-fg symbols to locate and change the
mapping consistently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1f3f1954-63b0-4a68-a6af-9a1ffe8088fe

📥 Commits

Reviewing files that changed from the base of the PR and between 63c0921 and 7adab4b.

⛔ Files ignored due to path filters (5)

• owlplug-client/src/main/resources/icons/check-green-16.png is excluded by !**/*.png, !**/*.png
• owlplug-client/src/main/resources/icons/cross-red-16.png is excluded by !**/*.png, !**/*.png
• owlplug-client/src/main/resources/icons/loading-grey-16.png is excluded by !**/*.png, !**/*.png
• owlplug-client/src/main/resources/icons/pen-grey-16.png is excluded by !**/*.png, !**/*.png
• owlplug-client/src/main/resources/icons/play-green-16.png is excluded by !**/*.png, !**/*.png

📒 Files selected for processing (6)

• owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.java
• owlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java
• owlplug-client/src/main/resources/fxml/HomeView.fxml
• owlplug-client/src/main/resources/fxml/projects/ProjectsView.fxml
• owlplug-client/src/main/resources/owlplug.css
• owlplug-theme/src/main/scss/owlplug-dark.scss

💤 Files with no reviewable changes (2)

• owlplug-client/src/main/resources/fxml/projects/ProjectsView.fxml
• owlplug-client/src/main/java/com/owlplug/core/components/ApplicationDefaults.java