Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions app/log_buffer.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from datetime import datetime
from typing import List, Literal
from collections import deque
from itertools import islice

LogLevel = Literal["init", "llm", "start", "tick", "action", "sl_tp", "stop", "error", "warn", "supervisor"]

Expand Down Expand Up @@ -31,11 +32,16 @@ def clear() -> None:


def get_logs(limit: int = 500) -> List[dict]:
"""Return last `limit` log entries, newest last."""
items = list(_buffer)
if limit and len(items) > limit:
items = items[-limit:]
return items
"""Return last `limit` log entries, newest last.

Avoid materializing the full ring buffer when callers only need a small
tail slice for the live logs endpoint.
"""
if not limit or limit >= len(_buffer):
return list(_buffer)

start = max(len(_buffer) - max(limit, 0), 0)
return list(islice(_buffer, start, None))


def get_logs_response(running: bool) -> dict:
Expand Down
23 changes: 23 additions & 0 deletions tests/test_log_buffer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
from app import log_buffer


def setup_function():
log_buffer.clear()


def test_get_logs_returns_only_requested_tail():
for index in range(10):
log_buffer.emit("tick", f"tick-{index}")

logs = log_buffer.get_logs(limit=3)

assert [entry["message"] for entry in logs] == ["tick-7", "tick-8", "tick-9"]


def test_get_logs_keeps_existing_unlimited_behavior():
for index in range(3):
log_buffer.emit("tick", f"tick-{index}")

logs = log_buffer.get_logs(limit=0)

assert [entry["message"] for entry in logs] == ["tick-0", "tick-1", "tick-2"]