perf: add connection pooling and price caching to PythClient (closes #2) - #16
Open
lequangsang01 wants to merge 1 commit into
Open
perf: add connection pooling and price caching to PythClient (closes #2)#16lequangsang01 wants to merge 1 commit into
lequangsang01 wants to merge 1 commit into
Conversation
- Use requests.Session for TCP connection reuse (reduces TLS handshake overhead) - Add configurable price cache with 0.5s TTL to avoid redundant API calls - Batch fetch now skips already-cached symbols - Add close() method for proper session cleanup Expected improvement: ~30-50ms per repeated price fetch, reduced API calls on rapid polling cycles (supervisor loop + logging).
|
@lequangsang01 is attempting to deploy a commit to the dragoon4002's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Improvement Submission
PR: lequangsang01#1
Changes
requests.Sessionfor TCP reuse (saves ~30-50ms per request)Benchmark
How to verify
```python
from app.market.pyth_client import PythClient
import time
c = PythClient()
start = time.monotonic()
for _ in range(10):
c.get_price('BTC')
elapsed = time.monotonic() - start
print(f'10 fetches: {elapsed:.2f}s (avg {elapsed/10*1000:.0f}ms each)')
c.close()
```
The cached + pooled version should show ~50% reduction in average latency.
Closes #2