Fix the Arch package verification in the release workflow - #9
Merged
Conversation
The release job asserted the core sits at /usr/bin/tenebra-core, which is where the hand-install script puts it, not the package: there the core and sing-box are private files under /usr/lib/tenebra and /usr/bin holds the desktop launcher named after the package. So a package that had built correctly failed verification and was never attached to the release. Check every path the package actually owns, assert the unit was rewritten to the packaged prefix, and run the installed core once to prove it resolves its engine through the ordinary search with nothing pre-set in the environment — which is the failure the old check was meant to catch and could not have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.4.6 release built the pacman package correctly but never attached it: the verification step checked
/usr/bin/tenebra-core, a path the package does not own. The package puts the core and sing-box under/usr/lib/tenebraand installs the desktop launcher as/usr/bin/tenebra.This checks the paths the package really installs, asserts the systemd unit was rewritten to the packaged prefix, and runs the installed core once to prove it finds its engine through the normal search — the failure the original check was aiming at and structurally could not detect.