Setup docker build on release#11
Conversation
D-Mantrid
left a comment
D-Mantrid
left a comment
There was a problem hiding this comment.
To be added on pre-release stage.
| RUN mkdir /app | ||
| WORKDIR /app | ||
| ADD requirements.txt . | ||
| RUN pip install -r requirements.txt |
There was a problem hiding this comment.
AFAIR, it is recommended to write pip install ... command with --no-cache-dir option as a good Docker practice.
It's not essential by now as we have no requirements at the moment, but you can add this option in the future.
There was a problem hiding this comment.
AFAIR, it is recommended to write
pip install ...command with--no-cache-diroption as a good Docker practice.
It's not essential by now as we have no requirements at the moment, but you can add this option in the future.
Well, I think now it's a right time to do this.
| # Other | ||
| *pycache* | ||
|
|
||
| .vscode No newline at end of file |
There was a problem hiding this comment.
We have already updated .gitignore with possible options for IDE stuff so that we have no need in this update.
| RUN mkdir /app | ||
| WORKDIR /app | ||
| ADD requirements.txt . | ||
| RUN pip install -r requirements.txt |
There was a problem hiding this comment.
AFAIR, it is recommended to write
pip install ...command with--no-cache-diroption as a good Docker practice.
It's not essential by now as we have no requirements at the moment, but you can add this option in the future.
Well, I think now it's a right time to do this.
| ### Docker build & run | ||
| ```bash | ||
| docker build -t pyndemic --rm . | ||
| docker run --rm -ti pyndemic |
There was a problem hiding this comment.
Please check that this docker command will end successfully.
Running the game by simple python pyndemic.py requires proceeding with some user input.
2 participants
No description provided.