chore(lint): fix pre-existing ST1005 capitalized error string#657
Closed
typefield wants to merge 1 commit into
Closed
chore(lint): fix pre-existing ST1005 capitalized error string#657typefield wants to merge 1 commit into
typefield wants to merge 1 commit into
Conversation
staticcheck flags one pre-existing ST1005 finding on main:
internal/generator/agentmetadata/metadata.go:372
fmt.Errorf("Agent hint directory is required")
-> fmt.Errorf("agent hint directory is required")
Go error strings must not be capitalized. Updates the one test that
asserts on this message text. No behavior change.
Verified: make lint (gofmt + go vet + staticcheck) passes.
Contributor
Author
|
Folded into #656 (cherry-picked onto that branch as a separate commit). Closing this in favor of the single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/generator/agentmetadata/metadata.go:"Agent hint directory is required"→"agent hint directory is required". Updated the one test (TestGenerateRequiresAgentHintDirectory) that asserts on this text.main. It is unrelated to any feature PR and CI does not currently enforce staticcheck (golangci-lint is disabled inci.ymldue to a Go-version incompatibility), so it has been lingering. Fixing it lets localmake lintgo fully green and re-enables the lint checklist item for contributors.Verification
make lint— gofmt + go vet + staticcheck all pass (was: 1 ST1005 finding)go test ./internal/generator/agentmetadata/—TestGenerateRequiresAgentHintDirectorypassesNotes
make lintlocally for feat(schema): split release Catalog into per-product shards to stop main-branch conflicts #656; kept separate to avoid scope creep there.