Keyboard hides part of the form - #5
Open
ulibath wants to merge 2 commits into
Open
Conversation
…sion button does not disappear behind the keyboard
maikz
suggested changes
Oct 23, 2023
| .frame(maxWidth: .infinity, maxHeight: .infinity) | ||
| .background(backgroundColor) | ||
| .ignoresSafeArea(edges: [.leading, .bottom, .trailing]) | ||
| .ignoresSafeArea(edges: [.leading, .trailing]) |
There was a problem hiding this comment.
There might have been a rationale behind this. I think we're more on the safe side if you define it for specific regions. What happens if you do .ignoresSafeArea(.container, edges: [.leading, .bottom, .trailing])?
Member
There was a problem hiding this comment.
Right. Maybe you can tell the inner scrollview to respect the safe area this way. There is also the .keyboard region, maybe that helps.
frankschlegel
requested changes
Oct 24, 2023
| .frame(maxWidth: .infinity, maxHeight: .infinity) | ||
| .background(backgroundColor) | ||
| .ignoresSafeArea(edges: [.leading, .bottom, .trailing]) | ||
| .ignoresSafeArea(edges: [.leading, .trailing]) |
Member
There was a problem hiding this comment.
Right. Maybe you can tell the inner scrollview to respect the safe area this way. There is also the .keyboard region, maybe that helps.
frankschlegel
approved these changes
Oct 24, 2023
maikz
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IOS-4493
Removed ignoreSafeAre .bottom from the submission form, so the submission button does not disappear behind the keyboard