Disable comment section - #2
Open
ulibath wants to merge 9 commits into
Open
Conversation
maikz
suggested changes
Sep 13, 2023
| private let descriptionLabel = UILabel(font: .systemFont(ofSize: 13), lineCount: WishKit.config.expandDescriptionInList ? 0 : 1) | ||
| private var descriptionLabel = UILabel(font: .systemFont(ofSize: 13), lineCount: WishKit.config.expandDescriptionInList ? 0 : 1) | ||
|
|
||
| public var isExpanded = WishKit.config.expandDescriptionInList { |
There was a problem hiding this comment.
Does this need to be a stored property or can it be computed?
Collaborator
Author
There was a problem hiding this comment.
This Boolean can be toggled to expand/shrink the WishCell by tapping on it. So I don't think it can be computed.
frankschlegel
approved these changes
Sep 15, 2023
# Conflicts: # Sources/WishKit/Controller/WishListVC.swift # Sources/WishKit/View/WishCell.swift # Sources/WishKit/ViewModel/WishListVM.swift
…for WishView expansion
maikz
approved these changes
Oct 5, 2023
frankschlegel
requested changes
Oct 25, 2023
| .multilineTextAlignment(.leading) | ||
| .lineLimit(descriptionLineLimit) | ||
| // By changing the id, the view is identified as a new view and we avoid the weird text animation. | ||
| .id(descriptionLineLimit) |
Member
There was a problem hiding this comment.
But don't you now have multiple views with the same ID in the hierarchy? Won't that be a problem?
Collaborator
Author
There was a problem hiding this comment.
Would it be okay to generate a new UUID() instead or should I create a unique id myself?
Member
There was a problem hiding this comment.
Maybe Text + line limit? Then the ID wouldn't change every time body is reevaluated.
frankschlegel
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.