Latest Ophyd-async API and add Tomography plans - #49
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## test_flyscan #49 +/- ##
===============================================
Coverage ? 48.40%
===============================================
Files ? 5
Lines ? 219
Branches ? 0
===============================================
Hits ? 106
Misses ? 113
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EmsArnold
left a comment
There was a problem hiding this comment.
Looks good at a first pass, I'd like to get it live on the beamline and properly test it though!
| hdf.array_counter: 3 | ||
| hdf.auto_increment: true | ||
| hdf.capture: false | ||
| hdf.chunk_size_auto: true | ||
| hdf.compression: None | ||
| hdf.create_directory: 0 | ||
| hdf.enable_callbacks: Enable | ||
| hdf.file_name: 5073260b-9688-4283-84d1-204955e423aa | ||
| hdf.file_number: 1 | ||
| hdf.file_path: /tmp/ | ||
| hdf.file_template: "%s%s.h5" | ||
| hdf.file_write_mode: Stream | ||
| hdf.flush_now: false | ||
| hdf.lazy_open: true | ||
| hdf.nd_array_address: 0 | ||
| hdf.nd_array_port: D2.ROISTAT | ||
| hdf.nd_attributes_file: "" | ||
| hdf.num_capture: 0 | ||
| hdf.num_extra_dims: 0 | ||
| hdf.num_frames_chunks: 1 | ||
| hdf.position_mode: false | ||
| hdf.queue_size: 2 | ||
| hdf.swmr_mode: true | ||
| hdf.xml_file_name: "" |
There was a problem hiding this comment.
Would be good to test these on the beamline to ensure they work as intended. The file was originally generated with the save_settings plan, so I assume there's been some change in the ophyd device to prompt this change here?
There was a problem hiding this comment.
Yes i think because of this. but i changed this manually actually, so once ophyd-async is updated we can run the save_settings plan again?
Will the tomography baselines be generated in the same way?
There was a problem hiding this comment.
Ah okay, that's fine. It would probably be good to run the save_settings plan again to make sure that everything is working as it should.
Yes, once we have a good set of settings for tomography, we should save and load those in the same manner. This should also help if we need different panda settings down the line.
|
|
||
| yield from load_panda_settings( | ||
| panda=pandabrick, | ||
| design_name="pandabrick_baseline", |
There was a problem hiding this comment.
I could see a world where you may want to have different panda setups for each fly scan, it may be good to allow this to be a variable passed into fly_scan (potentially with a default design_name = "pandabrick_baseline")
There was a problem hiding this comment.
Okay i will implement that, no downside
|
Additionally, I believe that some changes to |
Aims:
These also need to be implemented elsewhere alongside this PR:
1. New ophyd-async/dodal
2. Spectroscopy out of plans.py
3. Add tomography plans
Housekeeping